From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: dri-devel@lists.freedesktop.org, simona@ffwll.ch,
airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org,
hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com,
maarten.lankhorst@linux.intel.com,
linux-rockchip@lists.infradead.org, alok.a.tiwari@oracle.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
Date: Fri, 10 Oct 2025 23:00:16 +0200 [thread overview]
Message-ID: <5980548.GXAFRqVoOG@workhorse> (raw)
In-Reply-To: <20251010173143.72733-1-alok.a.tiwari@oracle.com>
On Friday, 10 October 2025 19:31:41 Central European Summer Time Alok Tiwari wrote:
> In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
> the RK3328 variant. This change updates it to the RK3228-specific mask
> RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
> I2C pin configuration for RK3228.
>
> Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK
>
> Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index 7b613997bb50..727cdf768161 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
>
> regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
> FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
> - FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
> + FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
> }
>
> static enum drm_connector_status
>
Oops, thanks.
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
In the future, please use something like get_maintainers or b4 to
make sure all recipients that should be included are included; in
this case, I'm very much interested in hearing of problems I
created.
Kind regards,
Nicolas Frattaroli
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-10-10 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 17:31 [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228 Alok Tiwari
2025-10-10 21:00 ` Nicolas Frattaroli [this message]
2025-10-16 16:01 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5980548.GXAFRqVoOG@workhorse \
--to=nicolas.frattaroli@collabora.com \
--cc=airlied@gmail.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).