* [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
@ 2025-10-10 17:31 Alok Tiwari
2025-10-10 21:00 ` Nicolas Frattaroli
2025-10-16 16:01 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Alok Tiwari @ 2025-10-10 17:31 UTC (permalink / raw)
To: dri-devel, simona, airlied, tzimmermann, mripard, hjc, heiko,
andy.yan, maarten.lankhorst
Cc: alok.a.tiwari, linux-arm-kernel, linux-rockchip
In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
the RK3328 variant. This change updates it to the RK3228-specific mask
RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
I2C pin configuration for RK3228.
Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK
Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 7b613997bb50..727cdf768161 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
- FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
+ FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
}
static enum drm_connector_status
--
2.50.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
2025-10-10 17:31 [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228 Alok Tiwari
@ 2025-10-10 21:00 ` Nicolas Frattaroli
2025-10-16 16:01 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Frattaroli @ 2025-10-10 21:00 UTC (permalink / raw)
To: Alok Tiwari
Cc: dri-devel, simona, airlied, tzimmermann, mripard, hjc, heiko,
andy.yan, maarten.lankhorst, linux-rockchip, alok.a.tiwari,
linux-arm-kernel, linux-rockchip
On Friday, 10 October 2025 19:31:41 Central European Summer Time Alok Tiwari wrote:
> In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
> the RK3328 variant. This change updates it to the RK3228-specific mask
> RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
> I2C pin configuration for RK3228.
>
> Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK
>
> Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> index 7b613997bb50..727cdf768161 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> @@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
>
> regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
> FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
> - FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
> + FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
> }
>
> static enum drm_connector_status
>
Oops, thanks.
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
In the future, please use something like get_maintainers or b4 to
make sure all recipients that should be included are included; in
this case, I'm very much interested in hearing of problems I
created.
Kind regards,
Nicolas Frattaroli
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
2025-10-10 17:31 [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228 Alok Tiwari
2025-10-10 21:00 ` Nicolas Frattaroli
@ 2025-10-16 16:01 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2025-10-16 16:01 UTC (permalink / raw)
To: dri-devel, simona, airlied, tzimmermann, mripard, hjc, andy.yan,
maarten.lankhorst, Alok Tiwari
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip
On Fri, 10 Oct 2025 10:31:41 -0700, Alok Tiwari wrote:
> In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references
> the RK3328 variant. This change updates it to the RK3228-specific mask
> RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and
> I2C pin configuration for RK3228.
>
> Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228
commit: c700e7279b29948f5d2aee30df2dbd3124df3b9c
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-16 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 17:31 [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228 Alok Tiwari
2025-10-10 21:00 ` Nicolas Frattaroli
2025-10-16 16:01 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).