From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3E5DCCD187 for ; Fri, 10 Oct 2025 21:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hGcxAUKKJ4LIyXb+CSkBgSlbODQrSg6RiDoo5DOLnko=; b=3TMhwwzi2jy1fC hrXEOGZUa4SGzB6Jg/MR6vfjxmo0Ofi6uTNgXuV/5xAq+6tz5HylQeeNt91gP2zNEAVchIvOPxL6R 5obH+LOYbU7iv3PrxdkKNd9tUpClMIhZmWmlCKKXKg4CIEDajGa+yYRO3zrTbgEPWOaYnaKDBdsRe 6mI5rHyH8GgGQy5QRD+JY4jsyEp2bVC+i7hJaICfbIDJ0rqVPzdWG/tT2xxLDfuuHWKefa46UfAJj U7SqbZDNbhcpzOFN7fw31yt6a49RuJwfmPnERXNuamjCqW6tdwVh42waMirZ6QEfr/V/qFPcjd1Xb DW77jM+HajHjq8G3o88g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v7KE7-00000009ODt-3KnX; Fri, 10 Oct 2025 21:00:35 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v7KE5-00000009ODH-0l5O; Fri, 10 Oct 2025 21:00:34 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1760130022; cv=none; d=zohomail.com; s=zohoarc; b=dNsLnuXKe8UFgg9g0TIytkHuxqJwEXV9BBDPda28muy+AXlVX8BsyOkHxo8UMbVBYZl8kowuJkdSRruENts6TosWDD5INkTgquUCuHjprvZ0TzgryDxM4ge98iNgT5B/FXvYmSz++jzD/PBG8r/kdc1+gmGt8AvT3aIoe3iAu0c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760130022; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=4OeIkartm93on5oAc/a8vf8nlOu9F7BGT4mVfpQiEsc=; b=fy1QCgQ16NzV87X7H0HW8yfiCCsv/vATGH9L7gA0dj8OqCPAhAZhB37B82takPJYTG9BbpkC/Q7qm6K6bKhdiKHULBhxn1Ujk7jUuZ9t6mfCaQ8gNt1uiG0BJ2Lwp6Aq3hAOiZiKvV8r/Cv3mAJ62IJTbq9ANfLApkw5DSQMmTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760130022; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=4OeIkartm93on5oAc/a8vf8nlOu9F7BGT4mVfpQiEsc=; b=URdI7/KPUKRgOo3n77+kSdOIRchPUdlJRuSm8l7sAuRJGqMtcwCf8jPSQRF3neLh Pclrcv4EDgalguyw9MaL7YGWFWu9YCLNSq+UhgJl2e64Vgbrflv554ro08K2sFyqkNO XgrQKlbRZnWJLfpbQsD3p5240dWHxwxCn9ETZPqs= Received: by mx.zohomail.com with SMTPS id 1760130020205726.9321883233297; Fri, 10 Oct 2025 14:00:20 -0700 (PDT) From: Nicolas Frattaroli To: Alok Tiwari Cc: dri-devel@lists.freedesktop.org, simona@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, linux-rockchip@lists.infradead.org, alok.a.tiwari@oracle.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228 Date: Fri, 10 Oct 2025 23:00:16 +0200 Message-ID: <5980548.GXAFRqVoOG@workhorse> In-Reply-To: <20251010173143.72733-1-alok.a.tiwari@oracle.com> References: <20251010173143.72733-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251010_140033_294945_9A30273A X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Friday, 10 October 2025 19:31:41 Central European Summer Time Alok Tiwari wrote: > In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references > the RK3328 variant. This change updates it to the RK3228-specific mask > RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and > I2C pin configuration for RK3228. > > Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK > > Fixes: 63df37f3fc71 ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros") > Signed-off-by: Alok Tiwari > --- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index 7b613997bb50..727cdf768161 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data) > > regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2, > FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) | > - FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1)); > + FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1)); > } > > static enum drm_connector_status > Oops, thanks. Reviewed-by: Nicolas Frattaroli In the future, please use something like get_maintainers or b4 to make sure all recipients that should be included are included; in this case, I'm very much interested in hearing of problems I created. Kind regards, Nicolas Frattaroli _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip