From: jeffy <jeffy.chen@rock-chips.com>
To: Sean Paul <seanpaul@chromium.org>, dri-devel@lists.freedesktop.org
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c
Date: Sat, 21 Oct 2017 07:14:19 +0800 [thread overview]
Message-ID: <59EA834B.4090807@rock-chips.com> (raw)
In-Reply-To: <20171020172557.54900-1-seanpaul@chromium.org>
Hi Sean,
On 10/21/2017 01:25 AM, Sean Paul wrote:
> I didn't catch this before applying, just right after (of course).
>
> Fixes:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function
> ‘rockchip_dp_of_probe’:
> ../drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:276:6: warning:
> unused variable ‘ret’ [-Wunused-variable]
> int ret;
> ^~~
sorry, i thought i fixed that, but it looks like i amended it to the
wrong commit by mistake...
>
> Fixes: 102712a32ff5 ("drm/rockchip: analogix_dp: Remove unnecessary init
> code")
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Mark Yao <mark.yao@rock-chips.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 8cae5ad926cd..39944c0f1c0b 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -273,7 +273,6 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
> {
> struct device *dev = dp->dev;
> struct device_node *np = dev->of_node;
> - int ret;
>
> dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
> if (IS_ERR(dp->grf)) {
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-20 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:25 [PATCH] drm/rockchip: Fix build warning in analogix_dp-rockchip.c Sean Paul
2017-10-20 23:14 ` jeffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59EA834B.4090807@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).