From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding Date: Wed, 17 Jan 2018 15:16:38 +0800 Message-ID: <5A5EF856.3090605@rock-chips.com> References: <20180116132540.18939-1-jeffy.chen@rock-chips.com> <20180116132540.18939-3-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tomasz Figa Cc: Heiko Stuebner , open-Y9sIeH5OGRo@public.gmane.org, list-Y9sIeH5OGRo@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ricky Liang , "open list:ARM/Rockchip SoC..." , IOMMU DRIVERS , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Tomasz, On 01/17/2018 01:32 PM, Tomasz Figa wrote: > On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa wrote: >> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen wrote: >>> It's not safe to unbind rockchip IOMMU driver. >> >> Might be good to explain why it is not safe and actually add that it >> does not make any sense for such low level devices. > > Actually, shouldn't we also remove support for .remove() and module > exit? I don't think it's actually feasible to unload this driver. We > actually even have ROCKCHIP_IOMMU Kconfig entry defined as bool, so > the driver can be only built-in. > right, will do it in the next version. > Best regards, > Tomasz > > >