From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Chaoyi Chen <kernel@airkyi.com>, Sandy Huang <hjc@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Dragan Simic <dsimic@manjaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Date: Fri, 9 May 2025 11:21:32 +0200 [thread overview]
Message-ID: <5c0a3b62-cf4f-46ec-b0e2-7d78ac499cb5@kernel.org> (raw)
In-Reply-To: <5a4f6229-1450-4c96-bfac-5257f66b2ddf@rock-chips.com>
On 09/05/2025 09:34, Chaoyi Chen wrote:
> Hi Krzysztof,
>
> On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
>> On 09/05/2025 09:02, Chaoyi Chen wrote:
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: core-clk
>>> + - const: pclk
>>> + - const: spdif
>>> + - const: grf
>>> +
>>> + extcon:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + description:
>>> + Phandle to the extcon device providing the cable state for the DP PHY.
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + phys:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> Just phandle. If this is an array (but why?), you need maxItems for
>> outer and inner dimensions.
Uh, sorry, that was supposed to be under extcon.
>
> I think it could be phandle or phandle-array. Since the RK3399 DP has
Here it is obviously not needed, that's a dtschema type.
> two PHYs, if we put in two PHYs here, the driver will pick one PHY port
> that is already plugged into the DP for output. If we fill in only one
> PHY here, then output is only allowed on the corresponding PHY.
>
> Will add restrictions and add more descriptions in v3.
>
>
>>
>>> + description:
>>> + Phandle to the PHY device for DP output.
You need to list the items with description iinstead.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-05-09 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 7:02 [PATCH v2 0/2] Convert Rockchip CDN DP binding to yaml Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 1/2] arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
2025-05-09 7:11 ` Krzysztof Kozlowski
2025-05-09 7:34 ` Chaoyi Chen
2025-05-09 7:46 ` Heiko Stübner
2025-05-09 9:21 ` Krzysztof Kozlowski [this message]
2025-05-09 9:32 ` Chaoyi Chen
2025-05-09 13:45 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0a3b62-cf4f-46ec-b0e2-7d78ac499cb5@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@airkyi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox