From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC87C87FCA for ; Tue, 29 Jul 2025 19:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GNTmGd4PnG1RVEjoed6uDI/jHYfb6XvLpqIpzL8eGak=; b=MrjeDMxbtFDHxL1/iZQE2dVs4X dmVUufJkzNwHzDtg9AW1gioHZEbecqFJ/znIjGn/JlOhscbi/XMagmmMykvup1KUS8pqMIX8IJQqg hBIVtOFfQzBblqnGp9FhcCAEogdMT+M/xmO9R2LNFBl8Rh1qMWvVzYnX2cay+z9Y0ZC5wf+HXskMA iEsAiETN4xvxOwWEWn7yMUJuHzYa9Jl3ROulLk+gvpAFOctCRfJdmYnM+etLVYkU9un7zjlzWyccq O73VGa6Bf6MrU91UB1A0k+BbanlsJIAm9eJoUDj7bRvMjJFqIBAEYM3VMSDGD6+kSKhVQEJQjiyBu AUI17wvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugpyJ-0000000HYQV-1K6w; Tue, 29 Jul 2025 19:26:47 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugpvn-0000000HYJC-149R; Tue, 29 Jul 2025 19:24:15 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1753817048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45b7+iFHqq41vN2poZPExRuxtRpUIdHR17dsbMnjiIQ=; b=A0BCxyrnYyclR+WVu3Wj43vGJTqP0k11ahIrdKi5DyWe4f+5DjKoxKPijRoi+LlX7ZI3yr CG6/zPkzOmq4O2kjcihAop6JTDB64bDn/rm4zYVZfs07ceOTgBmI65qhNWEjBLe5tp+KYB 6g1cjW8wPVvZfWuvtfNPYMJYryln3+dV2+4v9WVc00v6tzY0pi1jAhPjBr1yNtliUazcDb kOwjIwvdqEodc+4CDb2qeVYwoKastrAmMEjUElS142nXc053pjZPhO8xROckBWvUuzoVJj 6ECRDcFe/BInJPA/Jkgm/HNxgy0Lt5G8yO8h+y5gpeab+NPFni8MyUJw4wZGwg== Date: Tue, 29 Jul 2025 21:24:08 +0200 From: Dragan Simic To: Peter Robinson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Geert Uytterhoeven , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: Pinebook Pro: Update WiFi In-Reply-To: <6948463c8ca90bd9c72fb34178ddb029@manjaro.org> References: <20250729185827.144547-1-pbrobinson@gmail.com> <6948463c8ca90bd9c72fb34178ddb029@manjaro.org> Message-ID: <5c3a62a678f6d86e81913700c05e0286@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250729_122411_637907_6764D705 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 2025-07-29 21:10, Dragan Simic wrote: > Hello Peter, Sorry, somehow I managed to forget suggesting that the patch summary should be made a bit more self-descriptive. At the same time, including "Pinebook Pro:" as one of the summary prefixes isn't common, so perhaps this would be a good candidate for the revised patch summary: arm64: dts: rockchip: Describe WiFi wake-up pin for the Pinebook Pro Obviously, this applies to your PinePhone Pro patch [1] as well. As a nitpick, please note that the second "p" in "PinePhone" is actually an uppercase "P". [1] https://lore.kernel.org/linux-rockchip/20250729190712.145817-1-pbrobinson@gmail.com/T/#u > On 2025-07-29 20:58, Peter Robinson wrote: >> Update the WiFi configuration to include the wake-up >> pin and add an ethernet alias to allow assignment of >> a mac-address from the firmware. >> >> Signed-off-by: Peter Robinson >> --- >> .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 19 >> +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts >> b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts >> index 5a8551d9ffe47..05c48cb09df6f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts >> @@ -19,6 +19,7 @@ / { >> chassis-type = "laptop"; >> >> aliases { >> + ethernet0 = &brcmf; > > I'm sorry, but this alias isn't acceptable. In a few words, this > simply isn't an Ethernet interface. > > We're already stretching a bit the dynamic nature of, well, everything > with the aliases in the Rockchip DT files, and an alias like this one > would be stretching the whole thing beyond the breaking point. > >> mmc0 = &sdio0; >> mmc1 = &sdmmc; >> mmc2 = &sdhci; >> @@ -883,6 +884,12 @@ vcc5v0_host_en_pin: vcc5v0-host-en-pin { >> }; >> }; >> >> + wifi { >> + wifi_host_wake_l: wifi-host-wake-l { >> + rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>; >> + }; >> + }; >> + >> wireless-bluetooth { >> bt_wake_pin: bt-wake-pin { >> rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>; >> @@ -940,7 +947,19 @@ &sdio0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; >> sd-uhs-sdr104; >> + #address-cells = <1>; >> + #size-cells = <0>; >> status = "okay"; >> + >> + brcmf: wifi@1 { >> + reg = <1>; >> + compatible = "brcm,bcm4329-fmac"; >> + interrupt-parent = <&gpio0>; >> + interrupts = ; >> + interrupt-names = "host-wake"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wifi_host_wake_l>; >> + }; >> }; >> >> &sdhci { _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip