From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BED8CAC5A7 for ; Tue, 23 Sep 2025 01:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5FVhe2272Q4Ca1IMpVljFLUiRS5cSRpoyB+eA2XF3Wc=; b=oh3KVSJlEDA8v8 8/2SOuhNe3921KP9zGFXpfW7fxrFqBSYrjA5oZcZDW/XT8paN1V6J25F0WkIZiq/c6JEii7tKrG/Z q2ZV8bRjxg44hF3bHTtcW6+jYgQljNizzFAV+xJt2evx+yhkEOBNS6BAtaa7BLWhJgvfQ7Gga5Swt /1BraTFxVLGCi/dDXtn+xd+f/t8DqRcmGkwaTd+san5LkpwhI6HVN5e0L3a7Ejm1dZAz55e9k4/oC smqKht/VMfUqCPBxyGgWoef3NrtWEnIoVQg8NmfbA/AS1IyEcutAkwnTyMdo8/nxehtSHYeEf/3B3 3/qNAN9574a/Nqmj3xbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0rcv-0000000Bz1M-34mj; Tue, 23 Sep 2025 01:15:29 +0000 Received: from mail-m1973171.qiye.163.com ([220.197.31.71]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0rcs-0000000Bz0b-2oz6; Tue, 23 Sep 2025 01:15:28 +0000 Received: from [172.16.12.153] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 23b3334ac; Tue, 23 Sep 2025 09:15:15 +0800 (GMT+08:00) Message-ID: <5d078df4-4e0b-464b-9c2f-28b9a2669c5c@rock-chips.com> Date: Tue, 23 Sep 2025 09:15:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/7] drm/rockchip: cdn-dp: Support handle lane info without extcon To: Dmitry Baryshkov , Chaoyi Chen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Heikki Krogerus , Greg Kroah-Hartman , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20250922012039.323-1-kernel@airkyi.com> <20250922012039.323-5-kernel@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: X-HM-Tid: 0a9974239f4c03abkunmb38508cda8da5 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQ0JDSlZDGBhCH0NKQ09DT0JWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=COY5I7jkTU/zXnYTeQOMUc3ZPuGFmr7/r/7qdm6w5dIx4BIwgxKuHNnKEw48qSuL2b7I94/K+LtFixhilqgXOiMbji0L+k7o+/ueZ9uLqIghKjY/fF4rNBK3sPFb4H4n910b157/pQHZiPerd1v1I9xllp6XzfHxWzaziQqdB9A=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=TnzpHwo3q7997FFkEs8jwSh1z9SSMeRB7M3+4Ac9o8k=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250922_181527_190679_0182E8C2 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 9/22/2025 6:01 PM, Dmitry Baryshkov wrote: > On Mon, Sep 22, 2025 at 09:20:36AM +0800, Chaoyi Chen wrote: >> From: Chaoyi Chen >> >> This patch add support for get PHY lane info without help of extcon. >> >> There is no extcon needed if the Type-C controller is present. In this >> case, the lane info can be get from PHY instead of extcon. >> >> The extcon device should still be supported if Type-C controller is >> not present. >> >> Signed-off-by: Chaoyi Chen >> --- >> >> Changes in v4: >> - Remove cdn_dp_hpd_notify(). >> >> (no changes since v3) >> >> Changes in v2: >> - Ignore duplicate HPD events. >> >> drivers/gpu/drm/rockchip/cdn-dp-core.c | 25 +++++++++++++++++-------- >> 1 file changed, 17 insertions(+), 8 deletions(-) >> >> @@ -1120,14 +1129,14 @@ static int cdn_dp_probe(struct platform_device *pdev) >> PTR_ERR(phy) == -EPROBE_DEFER) >> return -EPROBE_DEFER; >> >> - if (IS_ERR(extcon) || IS_ERR(phy)) >> + if (IS_ERR(phy) || PTR_ERR(extcon) != -ENODEV) >> continue; > This will break the case when the extcon is present. It should be > (IS_ERR(extcon) && PTR_ERR(extcon) != -ENODEV) Yes, will fix in v5 > >> >> port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL); >> if (!port) >> return -ENOMEM; >> >> - port->extcon = extcon; >> + port->extcon = IS_ERR(extcon) ? NULL : extcon; >> port->phy = phy; >> port->dp = dp; >> port->id = i; >> -- >> 2.49.0 >> -- Best, Chaoyi _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip