From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3872C02182 for ; Wed, 22 Jan 2025 09:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0CPEIbvr1Fx+AGGkyGw4z8grdZaQVMdizRKyk/i6748=; b=aO37dv0tAKw0E0 CjCvZuVEE51LqPGEPmcHxA89T80XVWznXPZ/wFTaJcv9Dgfv1y34AcHNHo/G7D7z9SAogMBmE3jUs JbTOQaehueM3UVKFhPxGXa9uY/ECbdi78toZBzYJW5GFZCEmW5uq3swa3pDuSPFoigJ0+zpLPwJzX LEoQleyKqRUL/ZzheDa+DWg33igbRpTmgwVkC+R8AT18lHBZd0ilLV8mBY9nl+DSZlAzdXAUK/NK4 R/DKXVDjioG3HgIvDOJvywh0ia0Aq0pMSLdJtTCxL12aJNNNfSmU/bC/QWwPug/hfVMyrjk/JwMyV 1C9vUuZCHz/eP02Kawkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taXLY-00000009pfu-0QeF; Wed, 22 Jan 2025 09:48:28 +0000 Received: from m16.mail.163.com ([220.197.31.2]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1taXKE-00000009pSi-2Acv; Wed, 22 Jan 2025 09:47:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Content-Type:MIME-Version: Message-ID; bh=yWAJhbS/Q4MdxkCcBp+SmWjdnLYTjbVw2yNkD6kRxTc=; b=m iWC5lsm0JB7e8qPX/ddL0OKPtrrkSeIwIzLKvgnUSsRVh/Zg+YzrLPDF87BrHzDH HrcZ9sFV3DRLYMBHFyOmmroWmPOOdZiBpGippY2wgq1G3SjetN6VGAfDSFsl6rmH ku9VAl5yMiyEiQpl6AqFXNrs47lUSVAzVR9k7N6ECQ= Received: from andyshrk$163.com ( [58.22.7.114] ) by ajax-webmail-wmsvr-40-141 (Coremail) ; Wed, 22 Jan 2025 17:46:43 +0800 (CST) X-Originating-IP: [58.22.7.114] Date: Wed, 22 Jan 2025 17:46:43 +0800 (CST) From: "Andy Yan" To: "Krzysztof Kozlowski" Cc: heiko@sntech.de, hjc@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, daniel@fooishbar.org, robh@kernel.org, sebastian.reichel@collabora.com, "Andy Yan" Subject: Re:Re: [PATCH v12 12/13] dt-bindings: display: vop2: Add rk3576 support X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.14 build 20240801(9da12a7b) Copyright (c) 2002-2025 www.mailtech.cn 163com In-Reply-To: <20250122-amber-moth-of-upgrade-fa8331@krzk-bin> References: <20250121103254.2528004-1-andyshrk@163.com> <20250121103500.2528258-1-andyshrk@163.com> <20250122-amber-moth-of-upgrade-fa8331@krzk-bin> X-NTES-SC: AL_Qu2YBfmYtkor5SifbekfmkcVgOw9UcO5v/Qk3oZXOJF8jCrr+CUnVkFMJFbsweeONhCLrheYTj1O48h1bZN6b5MbkJYlmVCGtvKvPsZd0ZQhuQ== MIME-Version: 1.0 Message-ID: <5eb4acaa.6df6.1948d68332d.Coremail.andyshrk@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: jSgvCgD3v_uDvpBnS8lcAA--.18343W X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiqQvcXmeQtfafFwACse X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250122_014706_879607_35019F30 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi At 2025-01-22 16:04:59, "Krzysztof Kozlowski" wrote: >On Tue, Jan 21, 2025 at 06:34:57PM +0800, Andy Yan wrote: >> From: Andy Yan >> >> Add vop found on rk3576, the main difference between rk3576 and the >> previous vop is that each VP has its own interrupt line. >> >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v12: >> - Split from patch 10/13 > >Order your patches finally. It's v12 and you still send binding after >the user. Read carefully submitting bindings/patches. > >> >> Changes in v11: >> - Remove redundant min/maxItems constraint >> >> Changes in v10: >> - Move interrupt-names back to top level >> - Add constraint of interrupts for all platform >> - Add constraint for all grf phandles >> - Reorder some properties >> >> Changes in v9: >> - Drop 'vop-' prefix of interrupt-names. >> - Add blank line between DT properties >> - Remove list interrupt-names in top level >> >> Changes in v8: >> - Fix dt_binding_check errors >> - ordered by soc name >> - Link to the previous version: >> https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u >> >> Changes in v4: >> - describe constraint SOC by SOC, as interrupts of rk3576 is very >> different from others >> - Drop Krzysztof's Reviewed-by, as this version changed a lot. >> >> Changes in v3: >> - ordered by soc name >> - Add description for newly added interrupt >> >> Changes in v2: >> - Add dt bindings >> >> .../display/rockchip/rockchip-vop2.yaml | 55 ++++++++++++++++++- >> 1 file changed, 52 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> index 157a37ed84da..a2a6369c7b6f 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> @@ -21,6 +21,7 @@ properties: >> enum: >> - rockchip,rk3566-vop >> - rockchip,rk3568-vop >> + - rockchip,rk3576-vop >> - rockchip,rk3588-vop >> >> reg: >> @@ -38,10 +39,21 @@ properties: >> - const: gamma-lut >> >> interrupts: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 4 >> description: >> - The VOP interrupt is shared by several interrupt sources, such as >> - frame start (VSYNC), line flag and other status interrupts. >> + For VOP version under rk3576, the interrupt is shared by several interrupt >> + sources, such as frame start (VSYNC), line flag and other interrupt status. >> + For VOP version from rk3576 there is a system interrupt for bus error, and >> + every video port has it's independent interrupts for vsync and other video >> + port related error interrupts. >> + >> + interrupt-names: >> + items: >> + - const: sys >> + - const: vp0 >> + - const: vp1 >> + - const: vp2 >> >> # See compatible-specific constraints below. >> clocks: >> @@ -135,6 +147,8 @@ allOf: >> interrupts: >> maxItems: 1 > >So this change moves to this patch. > >> >> + interrupt-names: false >> + >> ports: >> required: >> - port@0 >> @@ -148,6 +162,39 @@ allOf: >> required: >> - rockchip,grf >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - rockchip,rk3576-vop >> + then: >> + properties: >> + clocks: >> + minItems: 5 > >No. You did not implement my comment at all. > >So again: >"Why minItems? Nothing in this patch makes sense for me. Neither changing >existing binding nor new binding for rk3576." Do you mean because I already defined minItems of clocks is 5 on the top, so there is no need to redefine the same minItems here ? > >To address such comment, come with reasonable answer to "why". Not just >send the same. It's a waste of my time to keep reviewing the same. Before sending this patch, I asked you what the next step should be, but you didn't respond. I might indeed have failed to grasp your main point, I'm indeed not writing dt-schema. Hope you can explain some of the specific issues in more detail to avoid wasting the time of both of us. > >Best regards, >Krzysztof > > >_______________________________________________ >Linux-rockchip mailing list >Linux-rockchip@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip