From: Damon Ding <damon.ding@rock-chips.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com,
p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de,
andy.yan@rock-chips.com, dianders@chromium.org,
m.szyprowski@samsung.com, luca.ceresoli@bootlin.com,
jani.nikula@intel.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 11/18] drm/display: bridge_connector: Ensure last bridge determines EDID/modes detection capabilities
Date: Thu, 9 Oct 2025 11:15:13 +0800 [thread overview]
Message-ID: <600da5e2-da28-429b-ba7a-6ddabeeb044d@rock-chips.com> (raw)
In-Reply-To: <4r25h5uaamfkprrmvrtdqfjlcgcnkfyca2o5q53hteta7rlrbq@xqlrjxhi7z2u>
Hi Dmitry,
On 10/1/2025 4:21 AM, Dmitry Baryshkov wrote:
> On Tue, Sep 30, 2025 at 05:09:13PM +0800, Damon Ding wrote:
>> When multiple bridges are present, EDID detection capability
>> (DRM_BRIDGE_OP_EDID) takes precedence over modes detection
>> (DRM_BRIDGE_OP_MODES). To ensure the above two capabilities are
>> determined by the last bridge in the chain, we handle three cases:
>>
>> Case 1: The later bridge declares only DRM_BRIDGE_OP_MODES
>> - If the previous bridge declares DRM_BRIDGE_OP_EDID, set
>> &drm_bridge_connector.bridge_edid to NULL and set
>> &drm_bridge_connector.bridge_modes to the later bridge.
>> - Ensure modes detection capability of the later bridge will not
>> be ignored.
>>
>> Case 2: The later bridge declares only DRM_BRIDGE_OP_EDID
>> - If the previous bridge declares DRM_BRIDGE_OP_MODES, set
>> &drm_bridge_connector.bridge_modes to NULL and set
>> &drm_bridge_connector.bridge_edid to the later bridge.
>> - Although EDID detection capability has higher priority, this
>> operation is for balance and makes sense.
>>
>> Case 3: the later bridge declares both of them
>> - Assign later bridge as &drm_bridge_connector.bridge_edid and
>> and &drm_bridge_connector.bridge_modes to this bridge.
>> - Just leave transfer of these two capabilities as before.
>>
>> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>> .../gpu/drm/display/drm_bridge_connector.c | 42 +++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> But I'd suggest pulling this to a top of the series to let others also
> take a look at it.
>
Will do in v7.
Best regards,
Damon
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-10-09 3:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250930091415eucas1p1f82ef0c96cbe0c7c673d975d502629e2@eucas1p1.samsung.com>
2025-09-30 9:09 ` [PATCH v6 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2025-09-30 9:09 ` [PATCH v6 01/18] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2025-09-30 9:09 ` [PATCH v6 02/18] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2025-09-30 9:09 ` [PATCH v6 03/18] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2025-09-30 9:09 ` [PATCH v6 04/18] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2025-09-30 20:10 ` Dmitry Baryshkov
2025-10-09 1:46 ` Damon Ding
2025-09-30 9:09 ` [PATCH v6 05/18] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2025-09-30 9:09 ` [PATCH v6 06/18] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2025-09-30 9:09 ` [PATCH v6 07/18] drm/exynos: exynos_dp: Apply legacy bridge to parse the display-timings node Damon Ding
2025-09-30 20:17 ` Dmitry Baryshkov
2025-10-09 2:01 ` Damon Ding
2025-09-30 9:09 ` [PATCH v6 08/18] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-09-30 9:09 ` [PATCH v6 09/18] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2025-09-30 20:18 ` Dmitry Baryshkov
2025-09-30 9:09 ` [PATCH v6 10/18] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2025-09-30 20:18 ` Dmitry Baryshkov
2025-09-30 9:09 ` [PATCH v6 11/18] drm/display: bridge_connector: Ensure last bridge determines EDID/modes detection capabilities Damon Ding
2025-09-30 20:21 ` Dmitry Baryshkov
2025-10-09 3:15 ` Damon Ding [this message]
2025-10-01 16:09 ` Luca Ceresoli
2025-10-03 7:34 ` Luca Ceresoli
2025-10-09 4:10 ` Damon Ding
2025-10-10 14:02 ` Dmitry Baryshkov
2025-10-11 1:04 ` Damon Ding
2025-09-30 9:09 ` [PATCH v6 12/18] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-09-30 9:09 ` [PATCH v6 13/18] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2025-09-30 10:17 ` [PATCH v6 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Marek Szyprowski
2025-10-09 1:29 ` Damon Ding
2025-09-30 20:29 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600da5e2-da28-429b-ba7a-6ddabeeb044d@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=imx@lists.linux.dev \
--cc=inki.dae@samsung.com \
--cc=jani.nikula@intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox