From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6D43CD4853 for ; Wed, 4 Sep 2024 17:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xHPGdNN+f5EZWU6L3JikF4hSr38KxZ6ozvZohbYOAWQ=; b=BQmP5VL9VZ4Vot pReYxHC0nW9zI/StAXYUQXxiZgmDiZUb2/FbMtM4zcVkPV2zn5tl0eBjIUTK4JYbg77fw42oK0GDQ 55friuQYKyUhMOEWvZ9eiJc3O16d3jyYVb1vOvNnVl4jIsUumA13a6JXkLaXWk2P7gl1JojOr0ZAb 7cJEFP3UYE+2/1ugIMy9O/8SPX8FVznRqr+dMiFMQkwo/eAiCZK92enHQ2MNvv0nrxb6JFyv5DMBv ZPHcxB/jNvOzAez61sp+WX/PIYx1z4Rpzm05JANUN0kJ+tBzQGJg4S6iZW95kNookal/vV932LMg/ JtCmjfyf4UFoPjN6CM0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sltmm-00000005SQJ-0JFj; Wed, 04 Sep 2024 17:27:16 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sltlp-00000005SHr-1jRS; Wed, 04 Sep 2024 17:26:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ny9mMZi9RGxeGZieQNyEsixXAXSWfxLduJAIPK++NZs=; b=26oqz/YjW8hGY0Zjw7tlQmVYlO lvdOdNESVddlfTk0kR/S/y7UtNH4vgeWFdvmTKhLOb1F+TZqKmvulivjT+NMJrx7peE/nLIzyVgJn IKg/1yZsyzmsgQdnLG5t9FA0FEpZSyN/xJJXn5YylD2qOyZ6tVlGmkv3oooHxqWMuYKw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sltlT-006aaf-CC; Wed, 04 Sep 2024 19:25:55 +0200 Date: Wed, 4 Sep 2024 19:25:55 +0200 From: Andrew Lunn To: Junhao Xie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Jonas Karlman , Chukun Pan , FUKAUMI Naoki , Dragan Simic , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568 Message-ID: <6030542f-070d-4d76-9a5a-fbfc6bd433e6@lunn.ch> References: <20240904111456.87089-1-bigfoot@classfun.cn> <20240904111456.87089-4-bigfoot@classfun.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240904111456.87089-4-bigfoot@classfun.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_102617_468801_A20B2F29 X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > +&gmac1 { > + assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; > + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>; > + assigned-clock-rates = <0>, <125000000>; > + clock_in_out = "output"; > + phy-handle = <&rgmii_phy1>; > + phy-mode = "rgmii"; > + phy-supply = <&vcc_3v3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac1m1_miim > + &gmac1m1_tx_bus2 > + &gmac1m1_rx_bus2 > + &gmac1m1_rgmii_clk > + &gmac1m1_rgmii_bus>; > + snps,reset-gpio = <&gpio4 RK_PC0 GPIO_ACTIVE_LOW>; > + snps,reset-active-low; > + snps,reset-delays-us = <0 20000 100000>; > + tx_delay = <0x38>; > + rx_delay = <0x15>; > + status = "okay"; This has been discussed a few times. You should be using phy-mode rgmii-id. arch/arm/boot/dts/rockchip/rk3288-phycore-som.dtsi is i think also a YT8521SC. Andrew _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip