From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5793C4332F for ; Thu, 14 Dec 2023 07:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AL2ZMEuFxFMgiPBVcCjlVgxDLeNL8AsvmqSGPZqKbiQ=; b=ZSjX6HmqIS1faVeEdY868B+BMB 4XF0vNYnSL4NYosPEI9z2C4YQm1b4ZCGJKDocuGDgZVxHsU7n5TnJt/NtoxHNH0i08c2di94cc0pv RwOMR9QCCjn3nvCwQdd1slPJmhPS/h39xKrGfh8+hk13a7HAZIlo7l/+cLH5wKK0KAvcqFlJCumxf CoElYeeeuVf3TXl+c0QwS9oLWVsM+wwHjeihiYg1iNmUXe/1dTvNXvasxDodm95pmlh42MPwlv9zg ++MAKj7ji1h21l7sgg9BF1w8ZPlamO/9sgTe9p9EuFeu1hoyKjaFUQ+ozG57uyt9rKenjRx1sT8Eu BJWpp+Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDfp7-00H3na-2J; Thu, 14 Dec 2023 07:07:57 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDfp4-00H3me-0B; Thu, 14 Dec 2023 07:07:56 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1702537669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YeV7T88snl53RFgpuP4C5JHNb6hLjpYKE/XnNP2YYbo=; b=jjnrRkZ7xobzuw20PCR8x87LIc5aCuTeZvPA1ATgp61Ob8c/IHBiA3KpL7OlX/A5FEMTBK eUtLAKy3AaB3m7DXp+U5mWfZU5UoqzIkqiJvYEJXMDEsJFwB8qzpeu3R9CLSeuL8gvZWsi Q2DlKKoADIRC8eLLfY6DNzI6PQW3t4Xk6k5nmOE+i5CskTn7KMG4zrHWlXg9UFg/6Pl1SF +AYG/kYPYVJ2iq86dHc46/1Vsj+qlUv0itifPkOC67ubwBkoPlcOSbV9QEcFqr0MhE8Kt4 8sfMjNtvC6spnDRu3IBRAA2ZM9J/2itTShoEjzXI+C+1T8SA4GWtI2DKMTfMFw== Date: Thu, 14 Dec 2023 08:07:48 +0100 From: Dragan Simic To: Trevor Woerner Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] arm64: rockchip: dts: rk3328-rock-pi-e: add gpio-line-names In-Reply-To: <20231213160556.14424-1-twoerner@gmail.com> References: <20231213160556.14424-1-twoerner@gmail.com> Message-ID: <62a0261fba6aecf5b28c4c55eb38ea51@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_230754_733627_26066BFD X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 2023-12-13 17:05, Trevor Woerner wrote: > Add names to the pins of the general-purpose expansion header as given > in the Radxa GPIO page[1] following the conventions in the kernel > documentation[2] to make it easier for users to correlate the pins with > functions when using utilities such as 'gpioinfo'. > > Signed-off-by: Trevor Woerner > --- > changes in v2: > - fix subject from "amd64..." to "arm64..." > --- > .../boot/dts/rockchip/rk3328-rock-pi-e.dts | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > index 018a3a5075c7..3169c0854061 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > @@ -388,3 +388,56 @@ &usbdrd3 { > &usb_host0_ehci { > status = "okay"; > }; > + > +&gpio0 { > + gpio-line-names = > + /* GPIO0_A0 - A7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO0_B0 - B7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO0_C0 - C7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO0_D0 - D7 */ > + "", "", "", "pin-15 [GPIO0_D3]", "", "", "", ""; > +}; > + > +&gpio1 { > + gpio-line-names = > + /* GPIO1_A0 - A7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO1_B0 - B7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO1_C0 - C7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO1_D0 - D7 */ > + "", "", "", "", "pin-07 [GPIO1_D4]", "", "", ""; > +}; > + > +&gpio2 { > + gpio-line-names = > + /* GPIO2_A0 - A7 */ > + "pin-08 [GPIO2_A0]", "pin-10 [GPIO2_A1]", "pin-11 [GPIO2_A2]", > + "pin-13 [GPIO2-A3]", "pin-27 [GPIO2_A4]", "pin-28 [GPIO2_A5]", > + "pin-33 [GPIO2_A6]", "", > + /* GPIO2_B0 - B7 */ > + "", "", "", "", "pin-26 [GPIO2_B4]", "", "", "pin-36 [GPIO2_B7]", > + /* GPIO2_C0 - C7 */ > + "pin-32 [GPIO2_C0]", "pin-35 [GPIO2_C1]", "pin-12 [GPIO2_C2]", > + "pin-38 [GPIO2_C3]", "pin-29 [GPIO2_C4]", "pin-31 [GPIO2_C5]", > + "pin-37 [GPIO2_C6]", "pin-40 [GPIO2_C7]", > + /* GPIO2_D0 - D7 */ > + "", "", "", "", "", "", "", ""; > +}; > + > +&gpio3 { > + gpio-line-names = > + /* GPIO3_A0 - A7 */ > + "pin-23 [GPIO3_A0]", "pin-19 [GPIO3_A1]", "pin-21 [GPIO3_A2]", > + "", "pin-03 [GPIO3_A4]", "", "pin-05 [GPIO3_A6]", "", > + /* GPIO3_B0 - B7 */ > + "pin-24 [GPIO3_B0]", "", "", "", "", "", "", "", > + /* GPIO3_C0 - C7 */ > + "", "", "", "", "", "", "", "", > + /* GPIO3_D0 - D7 */ > + "", "", "", "", "", "", "", ""; > +}; The formatting should be a bit different, i.e. all lines following "gpio-line-names =" and providing the value should be indented one tab position further. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip