From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>,
jic23@kernel.org, lars@metafoo.de, heiko@sntech.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, gustavo.padovan@collabora.com,
serge.broslavsky@collabora.com
Subject: Re: [PATCH 3/7] iio: adc: rockchip_saradc: Use of_device_get_match_data
Date: Wed, 17 May 2023 12:34:01 +0200 [thread overview]
Message-ID: <632269cc-db60-d405-d31f-b80a7faf1791@collabora.com> (raw)
In-Reply-To: <20230516230051.14846-4-shreeya.patel@collabora.com>
Il 17/05/23 01:00, Shreeya Patel ha scritto:
> Use of_device_get_match_data() to simplify the code.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> drivers/iio/adc/rockchip_saradc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 05b66eff9a44..05ea823a8f16 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -408,10 +408,10 @@ static void rockchip_saradc_regulator_unreg_notifier(void *data)
>
> static int rockchip_saradc_probe(struct platform_device *pdev)
> {
> + const struct rockchip_saradc_data *match_data;
s/match_data/data/g maybe?
Regardless of that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> struct rockchip_saradc *info = NULL;
> struct device_node *np = pdev->dev.of_node;
> struct iio_dev *indio_dev = NULL;
> - const struct of_device_id *match;
> int ret;
> int irq;
>
> @@ -425,13 +425,13 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
> }
> info = iio_priv(indio_dev);
>
> - match = of_match_device(rockchip_saradc_match, &pdev->dev);
> - if (!match) {
> + match_data = of_device_get_match_data(&pdev->dev);
> + if (!match_data) {
> dev_err(&pdev->dev, "failed to match device\n");
> return -ENODEV;
> }
>
> - info->data = match->data;
> + info->data = match_data;
>
> /* Sanity check for possible later IP variants with more channels */
> if (info->data->num_channels > SARADC_MAX_CHANNELS) {
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-05-17 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 23:00 [PATCH 0/7] RK3588 ADC support Shreeya Patel
2023-05-16 23:00 ` [PATCH 1/7] iio: adc: rockchip_saradc: Add support for RK3588 Shreeya Patel
2023-05-17 10:32 ` AngeloGioacchino Del Regno
2023-05-20 15:57 ` Jonathan Cameron
2023-05-16 23:00 ` [PATCH 2/7] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Shreeya Patel
2023-05-20 15:59 ` Jonathan Cameron
2023-05-16 23:00 ` [PATCH 3/7] iio: adc: rockchip_saradc: Use of_device_get_match_data Shreeya Patel
2023-05-17 10:34 ` AngeloGioacchino Del Regno [this message]
2023-05-16 23:00 ` [PATCH 4/7] iio: adc: rockchip_saradc: Match alignment with open parenthesis Shreeya Patel
2023-05-17 10:34 ` AngeloGioacchino Del Regno
2023-05-16 23:00 ` [PATCH 5/7] iio: adc: rockchip_saradc: Use dev_err_probe Shreeya Patel
2023-05-17 10:40 ` AngeloGioacchino Del Regno
2023-05-20 15:49 ` Jonathan Cameron
2023-05-16 23:00 ` [PATCH 6/7] arm64: dts: rockchip: Add DT node for ADC support in RK3588 Shreeya Patel
2023-05-17 10:41 ` AngeloGioacchino Del Regno
2023-05-16 23:00 ` [PATCH 7/7] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string Shreeya Patel
2023-05-17 8:49 ` Krzysztof Kozlowski
2023-05-20 16:00 ` [PATCH 0/7] RK3588 ADC support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=632269cc-db60-d405-d31f-b80a7faf1791@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox