From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
linux-can <linux-can@vger.kernel.org>,
1579567540@qq.com
Cc: Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
kernel <kernel@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Russell King <rmk+kernel@armlinux.org.uk>,
Eric Biggers <ebiggers@kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
Karl Mehltretter <kmehltretter@gmail.com>,
Yixun Lan <dlan@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible
Date: Thu, 2 Jul 2026 18:39:53 +0200 [thread overview]
Message-ID: <636d10c0-670d-4586-b604-7559d2a24185@kernel.org> (raw)
In-Reply-To: <2459655.BjyWNHgNrj@diego>
On 02/07/2026 18:01, Heiko Stübner wrote:
> Am Donnerstag, 2. Juli 2026, 16:06:51 Mitteleuropäische Sommerzeit schrieb 1579567540@qq.com:
>> From: Cunhao Lu <1579567540@qq.com>
>>
>> RK3588 integrates a Rockchip CAN-FD controller variant that is not
>> fully compatible with RK3568v2. The RX FIFO count register field is
>> encoded in bits 7:5 on RK3588, while RK3568v2 uses bits 6:4.
>>
>> Add a dedicated rockchip,rk3588-canfd compatible to describe this
>> variant. Do not use rockchip,rk3568v2-canfd as a fallback, because that
>> would describe a register layout that does not match the hardware.
>>
>> Changes in v2:
>> - Use enum for the single-compatible entries, as suggested by Krzysztof.
>> - Reword the commit message to explain the hardware difference instead
>> of referring to Linux driver match data.
>>
>> Signed-off-by: Cunhao Lu <1579567540@qq.com>
>
> after fixing Krzysztof's comment:
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> and doing dtbscheck of the binding against the dt-patches:
> Tested-by: Heiko Stuebner <heiko@sntech.de>
Makefile/build level steps are not testing. Please don't provide such
tags for bindings. Otherwise all bindings would carry Rob's tag, because
he wrote the bot which does such testing.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-07-02 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260702140654.2961561-1-1579567540@qq.com>
2026-07-02 14:06 ` [PATCH v2 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible 1579567540
2026-07-02 14:23 ` Krzysztof Kozlowski
2026-07-02 15:25 ` Cunhao Lu
2026-07-02 16:01 ` Heiko Stübner
2026-07-02 16:32 ` Cunhao Lu
2026-07-02 16:39 ` Krzysztof Kozlowski [this message]
2026-07-02 16:42 ` Heiko Stübner
2026-07-02 14:06 ` [PATCH v2 2/4] can: rockchip: add RK3588 CAN support 1579567540
2026-07-02 16:02 ` Heiko Stübner
2026-07-02 16:34 ` Cunhao Lu
2026-07-02 16:36 ` Heiko Stübner
2026-07-02 14:06 ` [PATCH v2 3/4] arm64: dts: rockchip: add CAN-FD nodes for RK3588 1579567540
2026-07-02 14:06 ` [PATCH v2 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou 1579567540
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636d10c0-670d-4586-b604-7559d2a24185@kernel.org \
--to=krzk@kernel.org \
--cc=1579567540@qq.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiggers@kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kmehltretter@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mailhol@kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mkl@pengutronix.de \
--cc=pengpeng@iscas.ac.cn \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox