From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] clk: rockchip: don't return NULL when failing to register ddrclk branch Date: Fri, 14 Oct 2016 19:06:00 +0200 Message-ID: <6436195.q1mHK715BP@phil> References: <1476275501-2653-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1476275501-2653-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Michael Turquette , Stephen Boyd , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lin Huang List-Id: linux-rockchip.vger.kernel.org Am Mittwoch, 12. Oktober 2016, 20:31:41 CEST schrieb Shawn Lin: > rockchip_clk_register_ddrclk should not return NULL when faling > to call clk_register, otherwise rockchip_clk_register_branches > prints "unknown clock type". The acutal case is that it's a known > clock type but we fail to regiser it, which may makes user confuse > the reason of failure. And the pr_err here is pointless as > rockchip_clk_register_branches will also print the similar message. > > Signed-off-by: Shawn Lin thanks for catching this ... applied to a clk-fixes branch for 4.9