Re: [PATCH v2] PCI: dw-rockchip: Add system PM support

From: Shawn Lin <shawn.lin@rock-chips.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: shawn.lin@rock-chips.com, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] PCI: dw-rockchip: Add system PM support
Date: Fri, 18 Apr 2025 08:27:24 +0800	[thread overview]
Message-ID: <6490464f-c47a-9a63-e0a1-251d52781c9d@rock-chips.com> (raw)
In-Reply-To: <aADdI7ByEImYy3Pq@ryzen>

Hi Niklas

在 2025/04/17 星期四 18:51, Niklas Cassel 写道:
> On Tue, Apr 15, 2025 at 03:09:29PM +0200, Niklas Cassel wrote:
>> On Fri, Apr 11, 2025 at 02:14:08PM +0800, Shawn Lin wrote:
> 
> (snip)
> 
>>> +
>>> +	rockchip_pcie_ltssm_enable_control_mode(rockchip, PCIE_CLIENT_RC_MODE);
>>
>> Here you are setting PCIE_CLIENT_RC_MODE unconditionally.
>>
>> I really don't think that you have tested these callbacks with EP mode.
>>
>> If we look at pcie-qcom.c and pcie-qcom-ep.c, dev_pm_ops is defined in
>> pcie-qcom.c, but not in pcie-qcom-ep.c.
>>
>> Perhaps it is starting to be time to have two separate drivers also for
>> rockchip?
> 
> Hmm.. looking at pcie-tegra194.c, they do still have both RC and EP in the
> same file, but they simply return -ENOTSUPP in the EP case:
> https://github.com/torvalds/linux/blob/v6.15-rc2/drivers/pci/controller/dwc/pcie-tegra194.c#L2381-L2384
> 
> Perhaps you could do something similar?

I'll look into it. Thanks for providing this useful hint.

> 
> 
> Kind regards,
> Niklas
> 
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip