From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DABC3CCFA05 for ; Thu, 6 Nov 2025 03:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7cl7ym4IMLFJibkqqmlR61gwHEncY1HzAudcT1gWQZA=; b=VAnaL0aeVbCIHQ h8btDHF9qxU0r29BghqmxY+jbC96y8hFV/RuKt4g+Oa+Jjy8bTtCL6OEUFEbW9HVMje0sygoUjjdZ +dyhskKj94kp37s3LxOOVNTib4dpP5d9wNQMGV4peolVjlz2nVIDEn3yRDAlQNx3GrolSSH1Ktrc5 OjYBDU6UVrzYTLKUeUUcUh+AhkbcmlQnHL68e+BOmJaLrrUGqm+GryLrvrEKrIo/l6mahk/M3mBVZ x7eKIDFOKZ32v4pZ+7Bp0sfHgQSHQhvj2s12Aw5AUJwow6JRFlbRaqSj2XUhZnbyljPL1CcRE4AeC /3PPjCJhAVMm0IAc7IKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGqL9-0000000Eng0-0TbH; Thu, 06 Nov 2025 03:07:11 +0000 Received: from mail-m128193.netease.com ([103.209.128.193]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGqL5-0000000EnfO-3DrY; Thu, 06 Nov 2025 03:07:09 +0000 Received: from [172.16.12.149] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2893b798a; Thu, 6 Nov 2025 11:06:56 +0800 (GMT+08:00) Message-ID: <64de56d4-43e8-4e77-a171-0bd0855ad816@rock-chips.com> Date: Thu, 6 Nov 2025 11:06:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 03/10] drm/bridge: Implement generic USB Type-C DP HPD bridge To: Dmitry Baryshkov , Chaoyi Chen Cc: Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20251029071435.88-1-kernel@airkyi.com> <20251029071435.88-4-kernel@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: X-HM-Tid: 0a9a5721af0c03abkunm89fae464e7fb72 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUtKHlZKSk1MSE5OS0kfTkpWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=evRfUVzE9gnJAOXo0XuZFWXMj+MLkXfh5miIhw12ck4N1iYs5TbQdrxU9sXAhiqRhN95j9bofAlR+87xDufP/ZBmz83i5dVRqQ8YiIiWE3TJThOgujLTjEgg/nXx4gfI/QUtvi+Nqf0kpUsoxBrB6H+DOC0XV+9rUTNW2AupTjQ=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=uxhO0QLYdKtAxkfwSVZCwZIlmY3EqbMoelKvCYvQETM=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251105_190708_354184_A26F3E49 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 11/3/2025 12:00 PM, Dmitry Baryshkov wrote: > On Wed, Oct 29, 2025 at 03:14:28PM +0800, Chaoyi Chen wrote: >> From: Chaoyi Chen >> >> Several USB-C controller drivers have already implemented the DP HPD >> bridge function provided by aux-hpd-bridge.c, but there are still >> some USB-C controller driver that have not yet implemented it. >> >> This patch implements a generic DP HPD bridge based on aux-hpd-bridge.c, >> so that other USB-C controller drivers don't need to implement it again. > This doesn't describe the problem that you are trying to solve. > >> Signed-off-by: Chaoyi Chen >> --- >> >> Changes in v8: >> - Merge generic DP HPD bridge into one module. >> >> drivers/gpu/drm/bridge/Kconfig | 5 +- >> drivers/gpu/drm/bridge/Makefile | 8 +++- >> drivers/gpu/drm/bridge/aux-hpd-bridge.c | 23 ++++++++- >> drivers/gpu/drm/bridge/aux-hpd-bridge.h | 13 +++++ >> .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 47 +++++++++++++++++++ >> 5 files changed, 93 insertions(+), 3 deletions(-) >> create mode 100644 drivers/gpu/drm/bridge/aux-hpd-bridge.h >> create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index a250afd8d662..17257b223a28 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -23,13 +23,16 @@ config DRM_AUX_BRIDGE >> build bridges chain. >> >> config DRM_AUX_HPD_BRIDGE >> - tristate >> + tristate "AUX HPD bridge support" > Why? No, this is supposed to be selected by other drivers. Users don't > know an wouldn't know what is this. > Sorry, I might have misunderstood you point. In v7, I added a new DRM_AUX_TYPEC_DP_HPD_BRIDGE module to select DRM_AUX_HPD_BRIDGE. This seems to fit the "selected by other drivers" scenario, but I think you might not want to expose any information to the users. And the other one is what Heikki said: +if DRM_AUX_HPD_BRIDGE + +config DRM_AUX_HPD_TYPEC_BRIDGE + tristate + depends on TYPEC || !TYPEC + default TYPEC + +endif /* DRM_AUX_HPD_BRIDGE */ + menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE If I understand correctly, in this scenario we need to select DRM_AUX_HPD_BRIDGE in the DP driver. When Type-C is available, DRM_AUX_HPD_TYPEC_BRIDGE will be selected automatically. Is the method mentioned by Heikki what you want? Thank you. -- Best, Chaoyi _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip