From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Shreeya Patel <shreeya.patel@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
jose.abreu@synopsys.com, nelson.costa@synopsys.com,
shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Tim Surber <me@timsurber.de>
Subject: Re: [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches
Date: Fri, 7 Mar 2025 12:58:13 +0300 [thread overview]
Message-ID: <64f8d179-9d0a-47ca-872c-aa92e44e7772@collabora.com> (raw)
In-Reply-To: <8cb4af0d-935a-4305-a204-9c2f187e0593@xs4all.nl>
On 3/7/25 12:54, Hans Verkuil wrote:
> Hi Dmitry,
>
> On 07/03/2025 10:21, Dmitry Osipenko wrote:
>> The pixelclock is specified as 64bit integer and for this driver it
>> won't be above 600MHz. Fix the 64bit division of the pixclock for 32bit
>> kernel builds.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202503070743.WnRxStlk-lkp@intel.com/
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>> drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> index 4d42da7255f3..7e342bbde967 100644
>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> @@ -291,7 +291,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev,
>> hfp = htotal - hact - hs - hbp;
>> vfp = vtotal - vact - vs - vbp;
>>
>> - fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
>> + fps = ((u32)bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
>
> I just merged:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20250306-synopsys-hdmirx-fix-64-div-v1-1-dd5ff38bba5e@kernel.org/
>
> So you can either leave that patch in, or provide a patch on top.
Missed that patch you merged. No need to do anything then, thanks!
--
Best regards,
Dmitry
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2025-03-07 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 9:21 [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches Dmitry Osipenko
2025-03-07 9:54 ` Hans Verkuil
2025-03-07 9:58 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f8d179-9d0a-47ca-872c-aa92e44e7772@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jose.abreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=me@timsurber.de \
--cc=nelson.costa@synopsys.com \
--cc=nicolas.dufresne@collabora.com \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox