Re: [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default

Stephen Boyd
2021-10-15T21:32:16Z

Quoting Alex Bee (2021-10-15 12:14:36)
>
> Am 14.10.21 um 23:34 schrieb Martin Blumenstingl:
> > On Thu, Oct 14, 2021 at 2:11 PM Martin Blumenstingl
> > <martin.blumenstingl@googlemail.com> wrote:
> > [...]
> >>> Reverting this commit makes it work again: Unless there is a quick and
> >>> obvious fix for that, I guess this should be done for 5.15 - even if the
> >>> real issue is somewhere else.
> >> Reverting this patch is fine from the Amlogic SoC point of view.
> >> The main goal was to clean up / improve the CCF code.
> >> Nothing (that I am aware of) is going to break in Amlogic land if we
> >> revert this.
> > Unfortunately only now I realized that reverting this patch would also
> > require reverting the other five patches in this series (since they
> > depend on this one).
> Indeed, that whole series would need have to reverted, which is clear
> (to me) when looking at the patches.
> > For this reason I propose changing the order of the checks in
> > clk-composite.c - see the attached patch (which I can send as a proper
> > one once agreed that this is the way to go forward)
>
> Yes, your patch papers over the actual issue (no best parent-selection
> in case determine_rate is used) and fixes it for now - as expected.
>
> But it is not a long-term solution, as we will be at the same point, as
> soon as round_rate gets removed from clk-divider. For me, who is
> semi-knowledged in clock-framework, it was relatively hard to figure out
> what was going on. "I'll do this later" has often been heard here.
>
> Though, I don't fully follow why moving the priority of determine_rate
> lower would have been necessary anyways: from what I understand
> determine_rate is expected to be the future-replacement of round_rate
> everywhere and should be preferred.

This is the only place I can see where we would have to keep round_rate
around, to mesh together rate rounding with parent selection. We can
probably stop using round_rate in the framework and only use it in the
composite code. It's not a big deal but it's sort of annoying that we
won't be able to fully remove round_rate from the clk_ops without
resolving this. Long term it may make sense to get rid of the composite
clk code entirely. It's pretty confusing code to read and encourages use
of the "basic clk types" which I'd like to see be used via direct
function calls instead of through clk_ops structures.