From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56EE8105F7A6 for ; Fri, 13 Mar 2026 13:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rhz+ujRY0bcP0evTypDaCeWryKKnA/0EikU1LUJggeY=; b=LzYVWLLduajpXa tSPAl6AblYmNgZMOVV1E/wyI0QWUwwDtyiuaZDb5n9PinWDR7BnS4YGyCfzzDcyl8cwX6+m/hIpV4 R1J1WW6g2dVEpfKp15JFFgPc/cvPq+CwmBwUz2snRpEaXoBGDMCUpJE9LEl862Gy77KVwc9jML5Ot 0LxZWlhVE9jzwCFQngS4z6vMKUh9RhTsLIvKYo1XIi36oLQKDihKlqdhFk+xmHL6Pc/fcgeVSUM0g +h3KbQrZF7LSHjwbI4ApLhsaaO5dTjjq9FVID5nmQWpEA3D1HD2YBuSDPdJfqlarWdEuKdhyu30+t WvM10+WUGEGZMYsHzwKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w12N5-00000000CT6-2yB5; Fri, 13 Mar 2026 13:16:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w12Ms-00000000COy-38K4; Fri, 13 Mar 2026 13:16:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 558D8497; Fri, 13 Mar 2026 06:15:45 -0700 (PDT) Received: from [10.57.59.200] (unknown [10.57.59.200]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D39153F73B; Fri, 13 Mar 2026 06:15:47 -0700 (PDT) Message-ID: <6cfe4bda-036f-4bb9-8a08-ed75f61cae24@arm.com> Date: Fri, 13 Mar 2026 13:15:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] PCI: dw-rockchip: Enable async probe by default To: Danilo Krummrich Cc: Manivannan Sadhasivam , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Niklas Cassel , Shawn Lin , Hans Zhang <18255117159@163.com>, Nicolas Frattaroli , Wilfred Mallawa , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Anand Moon , Grimmauld , Greg Kroah-Hartman , "Rafael J. Wysocki" , driver-core@lists.linux.dev, Lukas Wunner References: <20260226101032.1042-1-linux.amoon@gmail.com> <177260693908.10259.13055467642416391434.b4-ty@kernel.org> <87bc37ee-234c-4568-b72e-955c130a6838@arm.com> <5d88fb5b-e771-4ea6-8d2c-c5cfd21e5860@arm.com> <55c28218-1638-4b90-a9cd-a177fb5abcb6@arm.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260313_061559_789353_5CB7EFE1 X-CRM114-Status: GOOD ( 23.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 2026-03-12 12:59 pm, Danilo Krummrich wrote: > On Thu Mar 12, 2026 at 1:48 PM CET, Robin Murphy wrote: >> On 2026-03-11 9:09 pm, Danilo Krummrich wrote: >>> From a driver-core perspective I think we're rather limited on what we can do; >>> we are already in async context at this point and can't magically go back to >>> initcall context. >>> >>> So, the only thing I can think of is to kick off work on a workqueue, which in >>> the end would be the same as the deferred probe handling. >> >> Hmm, in fact, isn't the deferred probe mechanism itself actually quite >> appropriate? > > Yes, I've also mentioned this in [1], including the fact that it technically > even complies with the guarantees given by PROBE_FORCE_SYNCHRONOUS. I.e. the > documentation says: > > Use this to annotate drivers that need their probe routines to run > synchronously with driver and device registration (with the exception of > -EPROBE_DEFER handling - re-probing always ends up being done > asynchronously). > > However, I'm still not sure how I feel about this, since I consider this to be > more like a workaround that just moves things to a "more approprite" async > context. I guess the underlying problem there is that there are at least 3 different significant aspects to what "synchronous" can mean: - literally in the context or device/driver registration as documented. Off-hand I'm not really sure what useful property may be *specific* to those conditions that a driver might rely on, other than for super-special cases like platform_driver_probe(). - serialised, i.e. probes of multiple devices won't happen concurrently on multiple threads. This is probably the one hiding the most driver bugs, e.g. internal shared/global state without sufficient synchronisation. I guess this falls out as a side-effect of the first condition, but AFAICS it *can* also still provided by deferred probe (given that it's a single work item iterating a list one-by-one) - in some regular thread context that isn't liable to have issues synchronising against other async_func workers (i.e. the request_module case). Again, deferred can't have a problem here, or it wouldn't have worked properly in general for the last decade. So it's not that we'd be relying on some dubious "deferred is always synchronous" assumption - AFAICS deferred *can* launch async if the driver permits it - more just ratifying that deferred is still able to effectively honour all the useful properties of PROBE_FORCE_SYNCHRONOUS other than "during registration of the thing". And where people do want the semantics for a platform_driver_probe()-like thing, then I think it's reasonable to say that they should definitely never be invoking that from the probe routine of some other driver which permits async itself. Thanks, Robin. > > On the other hand, eventually we want everything to work with > PROBE_PREFER_ASYNCHRONOUS, so maybe it's also good enough for the time being. > > [1] https://lore.kernel.org/driver-core/DGZJBMG2Y738.2MU5LXVGEDD47@kernel.org/ _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip