From: Dragan Simic <dsimic@manjaro.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Christopher Obbard <chris.obbard@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Collabora Kernel Mailing List <kernel@collabora.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: rockchip: Add Firefly Core-PX30-JD4 with baseboard
Date: Thu, 18 Jul 2024 10:43:50 +0200 [thread overview]
Message-ID: <6ed3e6c6b74ddba1bca1a719dfdf3ac4@manjaro.org> (raw)
In-Reply-To: <20240718-lapped-suffocate-0216bad82c68@wendy>
On 2024-07-18 10:34, Conor Dooley wrote:
> On Thu, Jul 18, 2024 at 09:31:45AM +0100, Christopher Obbard wrote:
>> Thanks for the review.
>>
>> On Thu, 2024-07-18 at 06:36 +0200, Dragan Simic wrote:
>> > Hello Christopher,
>> >
>> > On 2024-07-17 18:46, Christopher Obbard wrote:
>> > > Add binding for the Firefly Core-PX30-JD4 SoM when used in conjunction
>> > > with the MB-JD4-RK3328 & PX30 baseboard.
>> > >
>> > > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
>> > > ---
>> > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>> > > 1 file changed, 6 insertions(+)
>> > >
>> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > index 1ef09fbfdfaf5..33ca8028bc151 100644
>> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > @@ -148,6 +148,12 @@ properties:
>> > > - const: engicam,px30-core
>> > > - const: rockchip,px30
>> > >
>> > > + - description: Firefly Core-PX30-JD4 with MB-JD4-PX30 baseboard
>> > > + items:
>> > > + - const: firefly,px30-mb-jd4
>> > > + - const: firefly,px30-core-jd4
>> >
>> > Similarly to how I suggested the new dts(i) files to be named, [1]
>> > the model names should be named like this:
>> >
>> > - const: firefly,px30-jd4-core
>> > - const: firefly,px30-jd4-core-mb
>>
>> I suppose the order should be the other way around to match other
>> entries, e.g
>> firefly,px30-jd4-core-mb first?
>
> Yes. Mainboard first, then som, then soc.
Ah yes, sorry, I somehow managed to get the order wrong. Basically,
it goes from more specific to less specific.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-07-18 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 16:46 [PATCH v2 0/3] Add support for Firefly Core-PX30-JD4 SoM & baseboard Christopher Obbard
2024-07-17 16:46 ` [PATCH v2 1/3] dt-bindings: arm: rockchip: Add Firefly Core-PX30-JD4 with baseboard Christopher Obbard
2024-07-18 4:36 ` Dragan Simic
2024-07-18 8:31 ` Christopher Obbard
2024-07-18 8:34 ` Conor Dooley
2024-07-18 8:43 ` Dragan Simic [this message]
2024-07-18 8:45 ` Christopher Obbard
2024-07-17 16:47 ` [PATCH v2 2/3] arm64: dts: rockchip: add Firefly Core-PX30-JD4 SoM Christopher Obbard
2024-07-17 16:47 ` [PATCH v2 3/3] arm64: dts: rockchip: add Firefly JD4 baseboard with " Christopher Obbard
2024-07-18 4:37 ` Dragan Simic
2024-07-18 4:33 ` [PATCH v2 0/3] Add support for Firefly Core-PX30-JD4 SoM & baseboard Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed3e6c6b74ddba1bca1a719dfdf3ac4@manjaro.org \
--to=dsimic@manjaro.org \
--cc=chris.obbard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox