From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues Date: Thu, 28 Feb 2019 21:30:59 +0100 Message-ID: <7232986.0TGCi46shW@phil> References: <20190228150129.28637-1-papadakospan@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190228150129.28637-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: "Leonidas P. Papadakos" Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Levin Du List-Id: linux-rockchip.vger.kernel.org Hi, Am Donnerstag, 28. Februar 2019, 16:01:29 CET schrieb Leonidas P. Papadakos: > The rk3328-roc-cc board exhibits tx stability issues with large packets, > as does the rock64 board, which was fixed with this patch > https://patchwork.kernel.org/patch/10178969/ > > A similar patch was made for the rk3328-roc-cc here > https://patchwork.kernel.org/patch/10804863/ > but it doesn't include the tx/rx fixes, and I fins that they > help with an issue where large transfers would bring the ethernet > link down, causing a reset. as you can see in the reference patchwork entry, I already applied that patch and it will be part of kernel 5.1. So please base you works on top of that state (like the linux-next for convenience) - i.e. your patch should not again try to add the thres_dma_mode property, as it is now already present in the devicetree. Thanks Heiko > Signed-off-by: Leonidas P. Papadakos > --- > arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > index 99d0d9912950..0e34354b2092 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > @@ -104,11 +104,12 @@ > phy-mode = "rgmii"; > pinctrl-names = "default"; > pinctrl-0 = <&rgmiim1_pins>; > + snps,force_thresh_dma_mode; > snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; > snps,reset-active-low; > snps,reset-delays-us = <0 10000 50000>; > - tx_delay = <0x25>; > - rx_delay = <0x11>; > + tx_delay = <0x24>; > + rx_delay = <0x18>; > status = "okay"; > }; > >