From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 287ECC77B61 for ; Sat, 8 Apr 2023 12:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KB3+s2MraEdtp6j7C/zgG5bTQLsU5iPNtuZQ8EdJthU=; b=WU3+RhGLFrMXmJ 68NTfVE2h16mYmVfM24Ms+2UtBAtHOZrxVbZWZf+ZlZ+gO4laj9dKsALYBDwNM1YrqP1C+cjTVg8a tOQP/L+yDhlsNz9u/02VUH4RFacKb4Fi1IS7sJx1p7KgAdwn56v3OH+ejB9pK5G6l0LnSokk8wBxs Ypzs4HLkXWMoxSNZExICeaz+UO//4aNlQur8SfHa4nFqjHFfvy1UkYGlW2y6EYNv1/ZFXjxNI6Zpn FYTJLgxJa4JjC05GB9m6pGWwJwrOdRtXPzZFVDbX5SCv1Zt0u5EaT77DSzmMsndzm8yNQ6Wug7gUD /E2r5YI5LLRCSlxyV7vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pl7Qa-00CGh2-2E; Sat, 08 Apr 2023 12:12:20 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pl7QX-00CGgL-08; Sat, 08 Apr 2023 12:12:18 +0000 Received: by mail-ej1-x634.google.com with SMTP id ud9so2226551ejc.7; Sat, 08 Apr 2023 05:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680955934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gsp6bAaqdkC+3l7L0QU9gWWFuWF86YUu16J9MyhyV3E=; b=Vzms7iQnafiqUkeMs1GMmPsw583bn+6RhHpsqKO6zfkfU10NzcwiOfy+EMZesNx5vb W+YGKbjYybKIxFFaYXDNotsBdrMm6NKOWtzAu6Yvjv3USDondpL9Ns2QsTGtrVTgd0Wg stS2FNX2Z3XSzrNDITuRIme9HfeIEahuuNLWvC06exD1Qjg1lv9/wjHLnb+arT4M2mtH g8w9lhCldDRNFrIV5VY1w98FYZKIwEDJqt0SUy2epVSqNrUkcsKdQfGAsgRMuDcVrFBi dhkdgQDTnRXFVF3EEBUsF5hphK0cX6AdpsOQoyHLUCyAiZ4sEQgNlvshf4rmgrD1cXEI ReZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680955934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gsp6bAaqdkC+3l7L0QU9gWWFuWF86YUu16J9MyhyV3E=; b=BSw5xn1sWWAyXU7QUv2g7d0is5fLzTm+VYud7rsVFOLLAAWqG++YuQOWu3yNCvirjD pAlGTLjAoBkR4fDXgyRH8za8TDxkS4xC1MF+modExffFMnYRnUtqYMsyJkXbIE37s7EC 8OdhV9cvz2YnWzIAptBzD1kRBAqeLThNoBYELQgtYKltU5qmH1bj4CqGMdpmZBt86+1W XsYq93lWyz3sM/IXZIwcmfOZ8iXPZNpcZPRR31OIpRL1Tiie0pyfS4YKJobjAzvNtUF3 ErPrUykI0HsxodjNJvMZwsNZFZrTRXEBJ5vR9BtoFGvFTEpOvZp51B2JJCMN9mLbWIOP d2Fw== X-Gm-Message-State: AAQBX9fhrK3sv4jU+X13wSh44F7zVuxT+mdzyHG2uj5OlskHhr7J1dQl NvZLW9PoZALc7jDCI1Rl/bs= X-Google-Smtp-Source: AKy350ZoljWQmJaFYZYXyiATILTnWWThGxROLCrvBR/uFCN9linJDLlNU8p8TFP9b2zvbHhV1DPxfg== X-Received: by 2002:a17:907:e91:b0:920:254c:1e2d with SMTP id ho17-20020a1709070e9100b00920254c1e2dmr2670313ejc.39.1680955934385; Sat, 08 Apr 2023 05:12:14 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id m2-20020a1709062ac200b008b176df2899sm3072135eje.160.2023.04.08.05.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 05:12:13 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nicolas Frattaroli , Cristian Ciocaltea Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v2 02/10] ARM: dts: sun6i: a31: Switch dma-names order for snps,dw-apb-uart nodes Date: Sat, 08 Apr 2023 14:12:12 +0200 Message-ID: <7505967.EvYhyI6sBW@jernej-laptop> In-Reply-To: <20230321215624.78383-3-cristian.ciocaltea@collabora.com> References: <20230321215624.78383-1-cristian.ciocaltea@collabora.com> <20230321215624.78383-3-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230408_051217_122648_A8D3AD71 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Dne torek, 21. marec 2023 ob 22:56:16 CEST je Cristian Ciocaltea napisal(a): > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > dma-names properties") documented dma-names property to handle Allwinner > D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the > reverse of what a bunch of different boards expect. > > The initial proposed solution was to allow a flexible dma-names order in > the binding, due to potential ABI breakage concerns after fixing the DTS > files. But luckily the Allwinner boards are not affected, since they are > using a shared DMA channel for rx and tx. > > Hence, the first step in fixing the inconsistency was to change > dma-names order in the binding to tx->rx. > > Do the same for the snps,dw-apb-uart nodes in the DTS file. > > Signed-off-by: Cristian Ciocaltea Acked-by: Jernej Skrabec Best regards, Jernej > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi > b/arch/arm/boot/dts/sun6i-a31.dtsi index 6cdadba6a3ac..5cce4918f84c 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -822,7 +822,7 @@ uart0: serial@1c28000 { > clocks = <&ccu CLK_APB2_UART0>; > resets = <&ccu RST_APB2_UART0>; > dmas = <&dma 6>, <&dma 6>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -835,7 +835,7 @@ uart1: serial@1c28400 { > clocks = <&ccu CLK_APB2_UART1>; > resets = <&ccu RST_APB2_UART1>; > dmas = <&dma 7>, <&dma 7>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -848,7 +848,7 @@ uart2: serial@1c28800 { > clocks = <&ccu CLK_APB2_UART2>; > resets = <&ccu RST_APB2_UART2>; > dmas = <&dma 8>, <&dma 8>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -861,7 +861,7 @@ uart3: serial@1c28c00 { > clocks = <&ccu CLK_APB2_UART3>; > resets = <&ccu RST_APB2_UART3>; > dmas = <&dma 9>, <&dma 9>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -874,7 +874,7 @@ uart4: serial@1c29000 { > clocks = <&ccu CLK_APB2_UART4>; > resets = <&ccu RST_APB2_UART4>; > dmas = <&dma 10>, <&dma 10>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -887,7 +887,7 @@ uart5: serial@1c29400 { > clocks = <&ccu CLK_APB2_UART5>; > resets = <&ccu RST_APB2_UART5>; > dmas = <&dma 22>, <&dma 22>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip