Re: [PATCH v3 1/3] dt-bindings: RNG: Add Rockchip RNG bindings

Diederik de Haas
2024-06-21T09:13:04Z

[-- Attachment #1.1: Type: text/plain, Size: 1565 bytes --]

Hi,

https://lore.kernel.org/all/89b16ec5-f9a5-f836-f51a-8325448e4775@linaro.org/
also mentions some remarks about the subject, so if I interpreted those
remarks correctly, it should be:

dt-bindings: rng: rockchip: Add rk3568 TRNG

On Friday, 21 June 2024 03:25:01 CEST Daniel Golle wrote:
> From: Aurelien Jarno <aurelien@aurel32.net>
>
> Add the RNG bindings for the RK3568 SoC from Rockchip
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/rng/rockchip,rk3568-rng.yaml | 60 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 66 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml
>
> diff --git a/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml
> b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml new file
> mode 100644
> index 000000000000..d45f03683fbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/rockchip,rk3568-rng.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rng/rockchip,rk3568-rng.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip TRNG
> +
> +description: True Random Number Generator on Rokchip RK3568 SoC

I *think* that the TRNG for rk3588 is different, so shouldn't the title be:

Rockchip TRNG for rk356x SoCs

Cheers,
Diederik

PS: Heiko's name is without `memcpy_fromio` ;-P

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]