public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Rob Herring <robh@kernel.org>
Cc: "Mehdi Djait" <mehdi.djait.k@gmail.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 02/14] media: dt-bindings: media: rockchip-cif: add port definitions
Date: Fri, 23 Feb 2024 07:53:58 +0100	[thread overview]
Message-ID: <7ee26662-caab-462b-a5f1-3267e55a6313@wolfvision.net> (raw)
In-Reply-To: <20240223002834.GA3933946-robh@kernel.org>

Hi Rob,

On 2/23/24 01:28, Rob Herring wrote:
> On Tue, Feb 20, 2024 at 10:39:12AM +0100, Michael Riesch wrote:
>> The different variants of the Rockchip Camera Interface may feature
>> various ports. Add a new header file with port definitions to avoid
>> hardcoded constants in device tree sources.
> 
> We generally don't do defines for 'port' numbering. I don't see a reason 
> to start.

OK. I'll drop patches 2 and 8, then.

Best regards,
Michael

>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  include/dt-bindings/media/rockchip-cif.h | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/include/dt-bindings/media/rockchip-cif.h b/include/dt-bindings/media/rockchip-cif.h
>> new file mode 100644
>> index 000000000000..37364ee1f7bc
>> --- /dev/null
>> +++ b/include/dt-bindings/media/rockchip-cif.h
>> @@ -0,0 +1,12 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (C) 2023 Michael Riesch <michael.riesch@wolfvision.net>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__
>> +#define __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__
>> +
>> +#define MEDIA_ROCKCHIP_CIF_DVP		0
>> +#define MEDIA_ROCKCHIP_CIF_MIPI		1
>> +
>> +#endif /* __DT_BINDINGS_MEDIA_ROCKCHIP_CIF_H__ */
>>
>> -- 
>> 2.30.2
>>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-02-23  6:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20  9:39 [PATCH 00/14] media: rockchip: cif: add support for rk3568 vicap Michael Riesch
2024-02-20  9:39 ` [PATCH 01/14] media: dt-bindings: media: video-interfaces: add defines for sampling modes Michael Riesch
2024-02-23  0:26   ` Rob Herring
2024-02-20  9:39 ` [PATCH 02/14] media: dt-bindings: media: rockchip-cif: add port definitions Michael Riesch
2024-02-23  0:28   ` Rob Herring
2024-02-23  6:53     ` Michael Riesch [this message]
2024-02-20  9:39 ` [PATCH 03/14] media: dt-bindings: media: rockchip,px30-vip: add optional property iommus Michael Riesch
2024-02-23  0:29   ` Rob Herring
2024-02-20  9:39 ` [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow for different variants Michael Riesch
2024-02-20 18:58   ` Conor Dooley
2024-02-23  7:03     ` Michael Riesch
2024-02-23 18:56       ` Conor Dooley
2024-02-20  9:39 ` [PATCH 05/14] media: dt-bindings: media: rockchip,px30-vip: add rk3568-vicap compatible Michael Riesch
2024-02-20  9:39 ` [PATCH 06/14] media: rockchip: cif: store endpoint information in private data Michael Riesch
2024-02-20  9:39 ` [PATCH 07/14] media: rockchip: cif: fix formatting of find_output_fmt Michael Riesch
2024-02-20  9:39 ` [PATCH 08/14] media: rockchip: cif: use port definitions from new header file Michael Riesch
2024-02-20  9:39 ` [PATCH 09/14] media: rockchip: cif: add support for grf Michael Riesch
2024-02-20  9:39 ` [PATCH 10/14] media: rockchip: cif: add variant specific input format list Michael Riesch
2024-02-20  9:39 ` [PATCH 11/14] media: rockchip: cif: make scaler support variant specific Michael Riesch
2024-02-20  9:39 ` [PATCH 12/14] media: rockchip: cif: make register access " Michael Riesch
2024-02-20  9:39 ` [PATCH 13/14] media: rockchip: cif: add support for rk3568 vicap Michael Riesch
2024-02-20  9:39 ` [PATCH 14/14] arm64: dts: rockchip: add vicap node to rk356x Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ee26662-caab-462b-a5f1-3267e55a6313@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait.k@gmail.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox