public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: "Paweł Jarosz" <paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: rockchip: Reserve unusable memory region on rk3066
Date: Tue, 4 Oct 2016 13:56:07 +0200	[thread overview]
Message-ID: <81d1fb8b-ee0e-35a7-77db-5e15c3f46449@gmail.com> (raw)
In-Reply-To: <2391111.dvDuarNnp9@phil>


>>>> I don't think this is a sane workaround, but it is at best difficult to
>>>> tell, given there's no reason given for why this memory is unusable.
>>>>
>>>> For instance, if bus accesses to this address hang, then this patch only
>>>> makes the hand less likely, since the kernel will still map the region
>>>> (and
>>>> therefore the CPU can perform speculative accesses).
>>>>
>>>> Are issues with this memory consistently seen in practice?
>>>>
>>>> Can you enable CONFIG_MEMTEST and pass 'memtest' to the kernel, to
>>>> determine if the memory is returning erroneous values?
>>> just for the sake of completeness, on the rk3288 the issue was the dma not
>>> being able to access the specific memory region (interestingly also the
>>> last 16MB but of the 4GB area supported on the rk3288). So memory itself
>>> was ok, just dma access to it failed.
>> How odd.
>>
>>> We didn't find any other sane solution to limit the dma access in a
>>> general way at the time, so opted for just blocking the memory region (as
>>> it was similarly only
>> I was under the impression that dma-ranges could describe this kind of
>> DMA addressing limitation. Was there some problem with that? Perhaps the
>> driver is not acquiring/configuring its mask correctly?
> I remember looking at (and trying) different options back then.
>
> dma-mask wanted power-of-2 values (so it's either 4GB or 2GB (or lower)),
> zone-dma was a 32bit (and non-dt) thing and dma-ranges seem to simply also
> calculate a dma-mask from the value, so you're down to 2GB again.
>
> So just blocking of those 16MB at the end for 4GB devices somehow sounded
> nicer than limiting dma access to only half the memory.
>
> I may be overlooking something but that was what I came up with last year.
>
>
> Heiko
Is there a chance to accept this patch?

I know it's not the best solution to this problem, but i don't know
a better one.

  reply	other threads:[~2016-10-04 11:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-01 14:09 [PATCH] ARM: dts: rockchip: Reserve unusable memory region on rk3066 =?UTF-8?q?Pawe=C5=82=20Jarosz?=
2016-10-01 18:17 ` Mark Rutland
2016-10-01 19:18   ` Heiko Stuebner
2016-10-01 19:59     ` Paweł Jarosz
2016-10-03 10:20     ` Mark Rutland
2016-10-03 10:54       ` Heiko Stuebner
2016-10-04 11:56         ` Paweł Jarosz [this message]
     [not found]           ` <81d1fb8b-ee0e-35a7-77db-5e15c3f46449-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-04 18:56             ` Heiko Stübner
2016-10-05  2:27 ` Huang, Tao
     [not found]   ` <6239b970-09d3-f7ee-e6f5-c019eaedb725-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-10-05  6:09     ` Paweł Jarosz
     [not found]       ` <f8aba48d-6c69-b246-4cb2-48a2770c80e4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-10  7:18         ` Huang, Tao
     [not found]           ` <67831fd0-76af-a793-0b2f-958e45633fe8-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-10-10  9:11             ` Paweł Jarosz
2016-10-13  7:12               ` Huang, Tao
     [not found]                 ` <e3746f9a-084e-163e-a412-1a1fc66926d5-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-10-13  8:55                   ` Paweł Jarosz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81d1fb8b-ee0e-35a7-77db-5e15c3f46449@gmail.com \
    --to=paweljarosz3691-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox