From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD769C63777 for ; Mon, 30 Nov 2020 09:07:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60AC12074A for ; Mon, 30 Nov 2020 09:07:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XyKYr5zz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60AC12074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JDExKeNFDPDpkpuHTmRJjXd3gyY43k65GRjQW9akVSs=; b=XyKYr5zz85fAiFNt3ttZs04D1 I9ZtekqLYpVu9YUBIe13RTwdw+NvGiCWHS4b8jXEpseFpN8B9xrCSroKeR2UkupHLhnW26ljjmXlE IA2PqiGH2mf3oRADI6TJNrk1zQ2r3NGhi9hiwrN7+k8gRzgWOEAIsvSMmPBc7tN47Hex+IRM4SodV kTMJd6LPz/4eYopGLpRHHeCM0u95t28Qw4pC5ZcSflgvO4j7q1lwI6riQFAWwWGwVnotX/EKeZZwP 6y6b7khTocORjZL0DO+CjDx9+QI7sEPUW8k/huzhltUBbYalCv/pcq39viOJ6LbQ/EivcJVZdmL2c BEL0AuXjw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjf9I-0005X7-BT; Mon, 30 Nov 2020 09:07:08 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjf9D-0005VU-V9 for linux-rockchip@lists.infradead.org; Mon, 30 Nov 2020 09:07:05 +0000 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-80-IWcXTuCBM3uUJIkbSzc7wQ-1; Mon, 30 Nov 2020 09:06:57 +0000 X-MC-Unique: IWcXTuCBM3uUJIkbSzc7wQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 30 Nov 2020 09:06:56 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 30 Nov 2020 09:06:56 +0000 From: David Laight To: =?utf-8?B?J0tyenlzenRvZiBXaWxjennFhHNraSc=?= , Bjorn Helgaas Subject: RE: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Topic: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Index: AQHWxqWOFrNLxNoH9E63s2U4AbPR/6ngYYng Date: Mon, 30 Nov 2020 09:06:56 +0000 Message-ID: <81f4ddc2f0524b4b80c8a0bfa2df57fe@AcuMS.aculab.com> References: <20201129230743.3006978-1-kw@linux.com> <20201129230743.3006978-5-kw@linux.com> In-Reply-To: <20201129230743.3006978-5-kw@linux.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_040704_200897_13CF2F07 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , "linux-pci@vger.kernel.org" , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michal Simek , "linux-rockchip@lists.infradead.org" , "bcm-kernel-feedback-list@broadcom.com" , Jonathan Derrick , Ray Jui , Florian Fainelli , "linux-rpi-kernel@lists.infradead.org" , Jonathan Cameron , "linux-arm-kernel@lists.infradead.org" , Scott Branden , Zhou Wang , Robert Richter , "linuxppc-dev@lists.ozlabs.org" , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Krzysztof Wilczynski > Sent: 29 November 2020 23:08 > > Use "void __iomem" instead "char __iomem" pointer type when working with > the accessor functions (with names like readb() or writel(), etc.) to > better match a given accessor function signature where commonly the > address pointing to an I/O memory region would be a "void __iomem" > pointer. ISTM that is heading in the wrong direction. I think (form the variable names etc) that these are pointers to specific registers. So what you ought to have is a type for that register block. Typically this is actually a structure - to give some type checking that the offsets are being used with the correct base address. If the code is using numeric offsets (hardware engineers like numeric offsets) then you can get some type protection by using a structure that only contains a single field (char in this case). David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip