From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD031C3ABBC for ; Wed, 7 May 2025 02:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PVBw/uj9SUwsPrgElP/FBVVw2sebngV8DGACFOuhHjk=; b=hAyyf5UrV0twSV eR3Mx1LBFAA4uZ1VM9pYXwqlQer0culH3XMTyzZMFZ2Ihi/P7V2sBb8fDJnWnlXjvWUOFEMRdCt2v 4bZKHWvgMI7PG4dZLBgcOH06lcZlt9NUbEl77dQnDqPrBrK2vf9gXZqMziFUZld6SSJybAgVjLDRT fK7FGQEqm8yMZS0938D4DRzotLcnVztmWOYkrKiCHdEHuj6BZn8v7MLaRNT1fx9KG5zNhtsFV62rO F3Er4sV6VOzNCSUo6SboYRLY4812kGfDp0tCMYSb2i6OONsVKEOxpFwzff1OwyJnrda34tMAcSRpH FgTwbIAtM6IuzpP/mEYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCUaV-0000000DuU7-0qaR; Wed, 07 May 2025 02:32:47 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCONS-0000000DHfa-23US; Tue, 06 May 2025 19:54:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1746561292; bh=TX6fnqyOQLRCqud7L1fLcyM5ocSTEz2pblmDAnAzXbs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=m7HJo9jl86sLv4qpeTc+fxgIuJA6St3d9IyKACbTZaZC6aWIHO6SCnopb3UOR1HTf LDl13EJMxzqGAz3J1wdnPXNK68paaGDnzQLhfbL8/IEhznNnrHp/VkeIv0WaDLSTYX +iOuMFyVfxBmSWp+mzaO5hkMM707SKDij4F0hTegTHveJCMRXIw42+yGTNCefzvYmP LhgTdC0f9v1sTf+e53HWJGNAkFqSfjZoOzRp/detfV1C6Zuxjdqbw9+ZkqVdhOr8do 8JCO++cM8Pt/3MURn4C9lN9JIskVvJs7huknkV2LCVDmXWhO33IJ7FtM/b0KTqFgzk oIWV7O3oGfdIw== Received: from [IPV6:2a05:1141:1cc:8600:1cd7:9a7e:17d7:cd2c] (unknown [IPv6:2a05:1141:1cc:8600:1cd7:9a7e:17d7:cd2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4380E17E10D3; Tue, 6 May 2025 21:54:51 +0200 (CEST) Message-ID: <82fd6088-2979-4a4b-8eb5-dd8da965369e@collabora.com> Date: Tue, 6 May 2025 21:54:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/13] media: dt-bindings: add rockchip rk3568 mipi csi receiver To: Mehdi Djait Cc: Maxime Chevallier , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Gerald Loacker , Thomas Petazzoni , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Michael Riesch References: <20240220-rk3568-vicap-v6-0-d2f5fbee1551@collabora.com> <20240220-rk3568-vicap-v6-5-d2f5fbee1551@collabora.com> Content-Language: en-US From: Michael Riesch In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250506_125454_833105_D08A40AA X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Mehdi, On 5/6/25 14:09, Mehdi Djait wrote: > Hi Michael, > > thank you for the patch! > > On Wed, Apr 30, 2025 at 11:15:54AM +0200, Michael Riesch via B4 Relay wrote: >> From: Michael Riesch >> >> Add documentation for the Rockchip RK3568 MIPI CSI-2 Receiver. >> >> Signed-off-by: Michael Riesch >> Signed-off-by: Michael Riesch >> --- >> .../bindings/media/rockchip,rk3568-mipi-csi.yaml | 113 +++++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 114 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml >> new file mode 100644 >> index 000000000000..d5004cb288dd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml >> @@ -0,0 +1,113 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/rockchip,rk3568-mipi-csi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Rockchip RK3568 MIPI CSI-2 Receiver >> + >> +maintainers: >> + - Michael Riesch >> + >> +description: >> + The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one input port >> + and one output port. It receives the data with the help of an external >> + MIPI PHY (C-PHY or D-PHY) and passes it to the Rockchip RK3568 Video Capture >> + (VICAP) block. >> + >> +properties: >> + compatible: >> + const: rockchip,rk3568-mipi-csi >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + phys: >> + maxItems: 1 >> + description: MIPI C-PHY or D-PHY. >> + >> + power-domains: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: Input port node. Connect to e.g., a MIPI CSI-2 image sensor. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + bus-type: >> + enum: [1, 4] > > shouldn't you add data-lanes property here ? Yes, makes sense. Thanks for pointing it out -- will be in v7. Best regards, Michael > > data-lanes: > minItems: 1 > maxItems: 4 >> + >> + required: >> + - bus-type > > and add it to required: > - data-lanes > > you are actually checking for data-lanes when you enable the stream in: > > rkcif-mipi-csi-receiver.c +226 > > u32 lanes = csi_dev->vep.bus.mipi_csi2.num_data_lanes; > > if (lanes < 1 || lanes > 4) > return -EINVAL; > >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Output port connected to a RK3568 VICAP port. >> + >> + required: >> + - port@0 >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - phys >> + - phy-names >> + - ports >> + - power-domains >> + - resets >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + csi: csi@fdfb0000 { >> + compatible = "rockchip,rk3568-mipi-csi"; >> + reg = <0x0 0xfdfb0000 0x0 0x10000>; >> + clocks = <&cru PCLK_CSI2HOST1>; >> + phys = <&csi_dphy>; >> + power-domains = <&power RK3568_PD_VI>; >> + resets = <&cru SRST_P_CSI2HOST1>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + csi_in: port@0 { >> + reg = <0>; >> + }; >> + >> + csi_out: port@1 { >> + reg = <1>; >> + >> + csi_output: endpoint { >> + remote-endpoint = <&vicap_mipi_input>; >> + }; >> + }; >> + }; >> + }; >> + }; > > -- > Kind Regards > Mehdi Djait _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip