Re: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe()

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Markus Mayer" <mmayer@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	zhanghongchen <zhanghongchen@loongson.cn>,
	"Yinbo Zhu" <zhuyinbo@loongson.cn>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Thara Gopinath" <thara.gopinath@gmail.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Yangtao Li" <tiny.windzz@gmail.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Julien Panis" <jpanis@baylibre.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Colin Ian King" <colin.i.king@gmail.com>,
	"Raphael Gallais-Pou" <rgallaispou@gmail.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Costa Shulyupin" <costa.shul@redhat.com>,
	"Yury Norov" <yury.norov@gmail.com>,
	"Cheng-Yang Chou" <yphbchou0911@gmail.com>,
	"Caleb Sander Mateos" <csander@purestorage.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	"Yangtao Li" <frank.li@vivo.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v6 01/24] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe()
Date: Mon, 23 Jun 2025 17:13:54 +0200	[thread overview]
Message-ID: <87a55ywkwd.fsf@bootlin.com> (raw)
In-Reply-To: <20250623123054.472216-2-panchuang@vivo.com> (Pan Chuang's message of "Mon, 23 Jun 2025 20:30:34 +0800")

Hi Pan,

On 23/06/2025 at 20:30:34 +08, Pan Chuang <panchuang@vivo.com> wrote:

> From: Yangtao Li <frank.li@vivo.com>
>
> There are more than 700 calls to devm_request_threaded_irq method and
> more than 1000 calls to devm_request_irq method. Most drivers only
> request one interrupt resource, and these error messages are basically
> the same. If error messages are printed everywhere, more than 2000 lines
> of code can be saved by removing the msg in the driver.

[...]

> So add devm_request_threaded_irq_probe() and devm_request_irq_probe(),
> which ensure that all error handling branches print error information.
> In this way, when this function fails, the upper-layer functions can
> directly return an error code without missing debugging information.
> Otherwise, the error message will be printed redundantly or missing.

While I understand the goal and adhere to it, may I challenge the use of
a yet another intermediate function that 99% of the users will anyway
use? Wouldn't it be more straightforward to just add the error message
in the existing functions directly? If we really want an alternative, it
may be created and called in the few places where a dev_err_probe()
might not be relevant.

Thanks,
Miquèl

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip