From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E70F6D75E2A for ; Fri, 22 Nov 2024 11:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kyp8aQbQjUu9kUTvZM/k9J0kfiHiTCnmgzzoEVQfCHo=; b=Uz34kARJ6gqOIW dTV67lsqWFquZLpgfzzrkVZHBDKqnlxGcx7FkKeoPBCUUmNSXpq6MifJdRfivQOR6TCx4c1keG4+J VB53oGcpSqFxkdw6Vp7S4f3Xd8v/mb/rAiDBVkf0ZB3/b1s18eWHWeWqgYgORfTxUEuUA/vb36uf0 8UtuVJ9ESIfGTnZ9pedgwYwnjA6a612PT61bnXCQvmH8yKtvlzC3dz8I7RF01pqCAIH7U6mJETLxi gf65Ryv8DqJFE2nCmxJ8fdYYJofb9mmuNMUEF+GMY3aw0Desyie/dKhfjQI18XwTZmquMuqTxVU1H bBH0y3ws6H7/zlGbcSdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tERlo-00000002MVc-4BEu; Fri, 22 Nov 2024 11:24:16 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tERkn-00000002MI8-2x5a; Fri, 22 Nov 2024 11:23:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732274594; x=1763810594; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=GJHZMDI2iJk8tkr/3YVQpA8tfSP7IWp9w/OqAk1Hxik=; b=SNwVswVS8ELltXxLW+GcfhyIU1AJwu1vMiC7+bedffpsvCmVvN0EcQBu fZ/DtAUu+f6OQXTq5rTdVfAuz77/nUy9XwhkII/QMz4KsvPmM/cj9+H72 jQCQAMFq+XS6u/rxlMpCjeC7PvWEJG+/2iVUIBLX0IKyPSTH7o9XxNG2H VYYHf0D2kKPg41W/X81XAC2yJZZIntKm31d4t4qdqtytuivnOWDALv7C8 MXXBxJ4Jd9SbLtOc3Xtj17kdJth/4gFN9EsnkEPjY+hOq0NMn03Y2FHeg 3tseGZJk9zXtwTOQgnUqDXaPUpZc0iboSTcU132+SFWuwVCYUphX6QqY8 w==; X-CSE-ConnectionGUID: 8khXGulmQhqLmp3FNetw7g== X-CSE-MsgGUID: si0wVRYoQ9+5m57tRz70ow== X-IronPort-AV: E=McAfee;i="6700,10204,11263"; a="43074367" X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="43074367" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2024 03:23:12 -0800 X-CSE-ConnectionGUID: 6Krw7KkLR6GVn5UaKuPNZg== X-CSE-MsgGUID: jti2QNpMQ/SNkFZUHXuDdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,175,1728975600"; d="scan'208";a="90532328" Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.157]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2024 03:23:00 -0800 From: Jani Nikula To: Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Phong LE , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Russell King , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Alain Volmat , Raphael Gallais-Pou Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 3/7] drm/connector: implement generic HDMI codec helpers In-Reply-To: <20241122-drm-bridge-hdmi-connector-v4-3-b4d69d6e3bd9@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241122-drm-bridge-hdmi-connector-v4-0-b4d69d6e3bd9@linaro.org> <20241122-drm-bridge-hdmi-connector-v4-3-b4d69d6e3bd9@linaro.org> Date: Fri, 22 Nov 2024 13:22:53 +0200 Message-ID: <87ed33zf5e.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241122_032313_790394_38174011 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, 22 Nov 2024, Dmitry Baryshkov wrote: > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index b2b6a8e49dda46f1cb3b048ef7b28356dd3aaa4e..8ed58e482fac4662b659276e8bc17690e1fdb9b7 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -280,4 +280,9 @@ void drm_framebuffer_print_info(struct drm_printer *p, unsigned int indent, > const struct drm_framebuffer *fb); > void drm_framebuffer_debugfs_init(struct drm_device *dev); > > +/* drm_connector_hdmi_codec.c */ > + > +int drm_connector_hdmi_codec_init(struct drm_connector *connector); > +void drm_connector_hdmi_codec_cleanup(struct drm_connector *connector); > + > #endif /* __DRM_INTERNAL_H__ */ Better fit in drm_crtc_internal.h or drm_crtc_helper_internal.h? Maybe we could use an internal header inside display/. Or just 1:1 drm_foo_internal.h for every drm_foo.c to keep things simple and have fewer interdependencies. BR, Jani. -- Jani Nikula, Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip