From: Devarsh Thakkar <devarsht@ti.com>
To: Sebastian Fricke <sebastian.fricke@collabora.com>
Cc: <mchehab@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <hverkuil-cisco@xs4all.nl>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>,
<benjamin.gaignard@collabora.com>,
<laurent.pinchart@ideasonboard.com>, <praneeth@ti.com>,
<nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>,
<j-luthra@ti.com>, <b-brnich@ti.com>, <detheridge@ti.com>,
<p-mantena@ti.com>, <vijayp@ti.com>, <andrzej.p@collabora.com>,
<nicolas@ndufresne.ca>, <afd@ti.com>
Subject: Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver
Date: Fri, 21 Jun 2024 18:14:16 +0530 [thread overview]
Message-ID: <8dda9d0c-3154-a7fd-1233-ca5be59639de@ti.com> (raw)
In-Reply-To: <20240621123715.enqtdqxskdkod5ze@basti-XPS-13-9310>
Hi Sebastian
On 21/06/24 18:07, Sebastian Fricke wrote:
> Hey Devarsh,
>
> This doesn't compile without errors for me, curious, it probably did
> compile without problems for you right?
>
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: error:
> initialization of ‘int (*)(struct platform_device *)’ from incompatible
> pointer type ‘void (*)(struct platform_device *)’
> [-Werror=incompatible-pointer-types]
> 1622 | .remove = e5010_remove,
> | ^~~~~~~~~~~~
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: note: (near
> initialization for ‘e5010_driver.remove’)
> cc1: some warnings being treated as errors
>
Yes I think it did compile fine for me.
Did you try this on tip of linux-next ?
As mentioned in changelog, there was update in platform driver for return type
of remove function which got changed to void return type. Please check if you
have this patch [1] in your tree which got recently merged.
Kindly let me know if you still face any issues.
[1]:
https://lore.kernel.org/all/20240527083416.1177106-2-u.kleine-koenig@pengutronix.de/
Regards
Devarsh
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-06-21 12:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 19:36 [PATCH v14 0/6] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 1/6] media: dt-bindings: Add Imagination " Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-06-18 20:46 ` Markus Elfring
2024-06-21 12:37 ` Sebastian Fricke
2024-06-21 12:44 ` Devarsh Thakkar [this message]
2024-06-21 13:26 ` Sebastian Fricke
2024-06-21 14:08 ` Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 3/6] media: v4l2-jpeg: Export reference quantization and huffman tables Devarsh Thakkar
2024-06-20 6:58 ` Hans Verkuil
2024-06-18 19:36 ` [PATCH v14 4/6] media: Documentation: Document v4l2-jpeg helper functions Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 5/6] media: imagination: Use exported tables from v4l2-jpeg core Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 6/6] media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dda9d0c-3154-a7fd-1233-ca5be59639de@ti.com \
--to=devarsht@ti.com \
--cc=a-bhatia1@ti.com \
--cc=afd@ti.com \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox