Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Junhao Xie <bigfoot@classfun.cn>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
	Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
	Dragan Simic <dsimic@manjaro.org>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for LCKFB Taishan Pi RK3566
Date: Mon, 26 Aug 2024 10:08:37 +0200	[thread overview]
Message-ID: <8e14d43b-598b-4aef-9c22-84122e17a77e@kernel.org> (raw)
In-Reply-To: <25346f43-642a-477d-8df5-91ddf2765d69@classfun.cn>

On 26/08/2024 09:46, Junhao Xie wrote:
> On 2024/8/26 14:06, Krzysztof Kozlowski  wrote:
>> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote:
>>> Add dts for LCKFB Taishan Pi.
>>>
> 
> [...]
> 
>>
>>> +	dc_12v: dc-12v {
>>
>> Use some reasonable prefix or suffix (regulator) for all regulator
>> nodes. Or even: use name for all fixed regulators which matches current
>> format recommendation: 'regulator-[0-9]v[0-9]'
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>>
> 
> Thanks, I will rename it to dc-12v-regulator

Well, this makes ordering tricky and is not the proposed policy, but
sure... I gave you reference hoping you will read it.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-08-26  8:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  4:44 [PATCH 0/3] Add support for LCKFB Taishan Pi RK3566 Junhao Xie
2024-08-26  4:44 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen JLC Technology Group LCKFB Junhao Xie
2024-08-26  6:04   ` Krzysztof Kozlowski
2024-08-26  4:44 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add LCKFB Taishan Pi RK3566 Junhao Xie
2024-08-26  6:04   ` Krzysztof Kozlowski
2024-08-26  4:44 ` [PATCH 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-08-26  6:06   ` Krzysztof Kozlowski
2024-08-26  7:46     ` Junhao Xie
2024-08-26  8:08       ` Krzysztof Kozlowski [this message]
2024-08-26  9:31         ` Junhao Xie
2024-08-26  7:01   ` Chukun Pan
2024-08-26  8:03     ` Junhao Xie
2024-08-28 15:14 ` (subset) [PATCH 0/3] Add support " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e14d43b-598b-4aef-9c22-84122e17a77e@kernel.org \
    --to=krzk@kernel.org \
    --cc=amadeus@jmu.edu.cn \
    --cc=bigfoot@classfun.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox