From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BD8C43461 for ; Mon, 7 Sep 2020 14:19:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF8C221481 for ; Mon, 7 Sep 2020 14:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e4YjOG6R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF8C221481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3qNDpy2fF/um6Z6rgo3YDKYn8Bs/7R3LEebXzFjKvfU=; b=e4YjOG6REn0v/0MRpppA8ARDw yGuzOveR8JZ7JVvrLW3VJj/ULN73b53U/XghXYTrSQoey2ov2/j/LP3TXiaZH4FJOtwDKMoEwV8sj 2RofQd6K9In6yJZV9nvnV1xqmr5wsu6qYtdIgiZ6NNEcIefOseEc77zlX5LMO9O4T+ma+w3EAkpYU 44HvHseBrRIW9ICa96+wbtWwOChZQmtjZ8dX8O3FCMZQLlNeo/H75RbqoCc6C4LUEyA5yrN4SFUaw /6/7KZYW8Un9toepHjsfs4Ah1Fwx8fv1DTUq99oUpA7Gq7kXt7f6oeTgEvJt/CdubZHAhw7QtXRQy pUr+zr00A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFHzS-0005an-FD; Mon, 07 Sep 2020 14:19:27 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFHzQ-0005ZB-3p for linux-rockchip@lists.infradead.org; Mon, 07 Sep 2020 14:19:25 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id B4DE72988B0 Subject: Re: [PATCH v4 03/10] media: staging: rkisp1: cap: remove unsupported format YUV444 To: Dafna Hirschfeld , linux-media@vger.kernel.org References: <20200901111612.10552-1-dafna.hirschfeld@collabora.com> <20200901111612.10552-4-dafna.hirschfeld@collabora.com> From: Helen Koike Message-ID: <9147c38d-790e-e486-5b6f-a8af922641b4@collabora.com> Date: Mon, 7 Sep 2020 11:19:06 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901111612.10552-4-dafna.hirschfeld@collabora.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_101924_233628_07CD47A3 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Dafna, On 9/1/20 8:16 AM, Dafna Hirschfeld wrote: > It is not clear if the device is able to support format > V4L2_PIX_FMT_YUV444M so remove it. > > Signed-off-by: Dafna Hirschfeld > --- > see the cover letter for details This commit message could have a bit more details, since it will remain in the git history. At least mentioning that it was tested in several configurations and you weren't able to get good frames. In any case: Acked-by: Helen Koike Thanks Helen > > drivers/staging/media/rkisp1/rkisp1-capture.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c > index 79195e74d995..022b8eeed426 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-capture.c > +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c > @@ -131,12 +131,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = { > .uv_swap = 1, > .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUV_PLA_OR_RAW8, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, > @@ -243,13 +237,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { > .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV420, > }, > - /* yuv444 */ > - { > - .fourcc = V4L2_PIX_FMT_YUV444M, > - .uv_swap = 0, > - .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, > - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV444, > - }, > /* yuv400 */ > { > .fourcc = V4L2_PIX_FMT_GREY, > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip