From: Dragan Simic <dsimic@manjaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook
Date: Fri, 02 Aug 2024 18:18:24 +0200 [thread overview]
Message-ID: <940a46cb471e8b561c393caf2bf3453d@manjaro.org> (raw)
In-Reply-To: <20240730102433.540260-2-andyshrk@163.com>
Hello Andy,
On 2024-07-30 12:24, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect with CM5.
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
Looking good to me, thanks for the v3.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
>
> Changes in v3:
> - Wrap commit message by a maximum 75 chars per line
> - Remove the superfluous blank line
> - Use "coolpi,pi-cm5-genbook" instead of "coolpi,genbook"
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 2ad835f4068e..18ea4160e3e2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,13 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,pi-cm5-genbook
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> - description: Cool Pi 4 Model B
> items:
> - const: coolpi,pi-4b
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-02 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 10:24 [PATCH v3 0/2] Add support for Cool Pi GenBook Andy Yan
2024-07-30 10:24 ` [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook Andy Yan
2024-08-02 16:18 ` Dragan Simic [this message]
2024-08-04 10:01 ` Krzysztof Kozlowski
2024-07-30 10:24 ` [PATCH v3 2/2] arm64: dts: rockchip: Add support for rk3588 based " Andy Yan
2024-08-10 19:15 ` [PATCH v3 0/2] Add support for Cool Pi GenBook Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940a46cb471e8b561c393caf2bf3453d@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox