From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Kochetkov Subject: Re: [PATCH 7/9] clocksource/drivers/rockchip_timer: implement clocksource timer Date: Thu, 24 Nov 2016 17:14:56 +0300 Message-ID: <95FE175F-B7B4-4271-99FE-69516140C56A@gmail.com> References: <1479922177-20136-1-git-send-email-al.kochet@gmail.com> <1800621.EhepfMxccR@diego> <0E972AC9-1132-4D0B-BF25-918BC1AA1A49@gmail.com> <4357439.aV0xjsImc7@diego> Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4357439.aV0xjsImc7@diego> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?Q?Heiko_St=C3=BCbner?= Cc: daniel.lezcano@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org > 24 =D0=BD=D0=BE=D1=8F=D0=B1. 2016 =D0=B3., =D0=B2 16:21, Heiko = St=C3=BCbner =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(= =D0=B0): >=20 > what I actually meant was that the driver could also recognize the = rk3188- > timer compatible as "we need a clocksource" and it shouldn't matter = which=20 > timer actually gets used for this. One rockchip timer cannot be used as clockevent and clocksource at the = same time. In case of clockevent we want interrupts from it at specified times. So = we load one value into timer counter and it generates an interrupt. In case of clocksource we load max value into timer counter, run timer = and read current value on demand. rockchip_timer driver currently implement clockevent. So, if I create = only one timer in the device tree, it should be clockevent timer. As that behavior = already expected from driver by people used it. I may suggest such solution here: if I want clocksource, I have to = declare two timer in device tree. First probed timer would be clockevent and second one = would be clocksource. All other timers will be ignored. Is that solution good? If I want one timer and want it be clocksource not clockevent how that = situation should be configured? Device tree not good for this. Kconfig not good. Pass = that configuration on kernel command line? > Only devicetree people can really tell you if that is ok :-) . >=20 > The devicetree is supposed to be a hardware-description and = implementation- > independent, so rockchip,clocksource sounds pretty much like = linux-specific=20 > configuration things leaking into the devicetree. You are right. They don=E2=80=99t allow pass linux configuration using = device tree.=20 Regards, Alexander.