Re: [PATCH v3 3/5] pwm: Add rockchip PWMv4 driver

Nicolas Frattaroli
2025-11-14T10:14:00Z

On Friday, 14 November 2025 10:51:27 Central European Standard Time you wrote:
> On Tue, Oct 28, 2025 at 04:16:26PM +0800, Damon Ding wrote:
> > Hi Nicolas,
> >
> > On 10/28/2025 1:11 AM, Nicolas Frattaroli wrote:
> > > [...]
> > >
> >
> > Tested-by: Damon Ding <damon.ding@rock-chips.com>
> >
> > I have tested all the PWM channels in continuous mode on my RK3576-IOTEST
> > board.
> >
> > Test commands are like:
> >
> > cd /sys/class/pwm/pwmchip0/
> > echo 0 > export
> > cd pwm0
> > echo 10000 > period
> > echo 5000 > duty_cycle
> > echo normal > polarity
> > echo 1 > enable
>
> Thanks for the test, very appreciated.
>
> I wonder what made you test using sysfs instead of
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/libpwm.git/.
> Is it unknown? Too complicated? Other problems?

Can't speak for Damon Ding but this is the first time I've heard of
libpwm, so I think you do need to market it better. :) Perhaps by
mentioning it in the PWM subsystem docs as a way to interface with
the kernel, if that's permitted by the docs people. (It should be,
since libiio is mentioned for IIO.)

Kind regards,
Nicolas Frattaroli

>
> Best regards
> Uwe