From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07562E7717F for ; Tue, 10 Dec 2024 11:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:References:Cc:To:From:Subject:Message-Id:Date:Mime-Version: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D+LJhmPZTmYip/IoqfiWokttaeFX3X4OY0iGMX361dA=; b=VdXj1VqocXzPB5eMHkOdP8L7TS dOgwbrDUOEjy8uaOxgWDXhz87/Kn+8CbImQPE6sjS6vCVyykeOhZV9iHyBn5qiKjqtjecUIUIqi31 G8pRlvQHTqhiiZtYibPUynWQ+fEC8mU5Rcr8gIdzaPrjbLcv+dDo4sGPOYsenhmOQYFku0Rb6xGj1 Hw+RoZ9uEQh1uE9tV0NsZh0NnLGf7xONPh4LYvKxm5qeYskWdU93qhwyQ+DXrO8re8niE9Cva8+9Y woFTb71vg9BBRnShfVnFg6fPvLNRqFmp2rUnrwjYWDstcODoY3Rg8FxhXj4sNK4TtccJDD7XpjKpY fapBhngw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tKyTW-0000000BKC9-0ne5; Tue, 10 Dec 2024 11:32:22 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tKySa-0000000BJvS-3Mr3 for linux-rockchip@lists.infradead.org; Tue, 10 Dec 2024 11:31:26 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1733830272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dC9p5FCQHs2anWJcb1DSJZ9Qt5OmqJaqiCA2H3GVUdA=; b=rhbg1cnDCmr4+sq42ofOWItwWMMrQ/fu3jv83RueAD29byK8AuCHomk+TOanv7eTttbQ4O SlK3EjM51VoQtoedkuRdy9/wxUoYnw1tJb5P19ZzuLkzRPyIYhI/Xe9nRsIeXFGf6RZVyh PPRxoFJPVc+Ddh50sp6ecHS6VDOTRDXIA6KddPPRunRntp8cWBkfR+q7WrMsFPL7m6O1AB KLUl/t3jylitbOMRyfrs4zeQGCg2bQOlWC1TqPn3BTkkPJZVMt2Gt2CP/0TxispyBNtH/q RwHbfXmksyJ2Hrwjt2N+NcwGxdhaVhXsaLkqJpemT8rCJgdpM7+I0KEFca0zJA== Date: Tue, 10 Dec 2024 12:31:02 +0100 Message-Id: Subject: Re: [PATCH 5/6] arm64: dts: rockchip: correct rk3328-roc regulator map X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Peter Geis" , "Heiko Stuebner" Cc: "Conor Dooley" , "Dragan Simic" , "Johan Jonker" , "Krzysztof Kozlowski" , "Levin Du" , "Rob Herring" , , , , References: <20241210013010.81257-1-pgwipeout@gmail.com> <20241210013010.81257-6-pgwipeout@gmail.com> In-Reply-To: <20241210013010.81257-6-pgwipeout@gmail.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241210_033125_131720_618347A5 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3227075082022791583==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============3227075082022791583== Content-Type: multipart/signed; boundary=768b44e4608be46521de5d39885a4e035e23bf1739a34b0bd3d7b81b3cbe; micalg=pgp-sha256; protocol="application/pgp-signature" --768b44e4608be46521de5d39885a4e035e23bf1739a34b0bd3d7b81b3cbe Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Peter, Thanks for this series, I already saw some familiar error msgs mentioned, so will try this series out soon (tm). On Tue Dec 10, 2024 at 2:30 AM CET, Peter Geis wrote: > The rk3328-roc-cc input power is sourced from a micro-usb port, while > the rk3328-roc-pc input power is sourced from a usb-c port. Both inputs > are 5vdc only. Remove the 12v input from the device tree. > > While we are at it, add missing voltages and supply to vcc_phy, missing > voltages to vcc_host1_5v, and standardize the order of regulator > properties among the fixed regulators. Big fan of standardization :-) ... > > Fixes: 2171f4fdac06 ("arm64: dts: rockchip: add roc-rk3328-cc board") > Signed-off-by: Peter Geis > --- > > arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 23 +++++++++++++------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/bo= ot/dts/rockchip/rk3328-roc.dtsi > index f782c8220dd3..6984387ff8b3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi > @@ -24,22 +24,23 @@ gmac_clkin: external-gmac-clock { > #clock-cells =3D <0>; > }; > =20 > - dc_12v: regulator-dc-12v { > + /* fed from passive usb input connector */ > + dc_5v: regulator-dc-5v { > compatible =3D "regulator-fixed"; > - regulator-name =3D "dc_12v"; > + regulator-name =3D "dc_5v"; > regulator-always-on; > regulator-boot-on; > - regulator-min-microvolt =3D <12000000>; > - regulator-max-microvolt =3D <12000000>; > + regulator-min-microvolt =3D <5000000>; > + regulator-max-microvolt =3D <5000000>; > }; > =20 > vcc_sd: regulator-sdmmc { > compatible =3D "regulator-fixed"; > + regulator-name =3D "vcc_sd"; > gpio =3D <&gpio0 RK_PD6 GPIO_ACTIVE_LOW>; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&sdmmc0m1_pin>; > regulator-boot-on; > - regulator-name =3D "vcc_sd"; > regulator-min-microvolt =3D <3300000>; > regulator-max-microvolt =3D <3300000>; > vin-supply =3D <&vcc_io>; ... but why not put regulator-name as the first of the regulator properties as is done in the rk3328-rock64.dts ... > @@ -50,22 +51,25 @@ vcc_sdio: regulator-sdmmcio { > states =3D <1800000 0x1>, <3300000 0x0>; > regulator-name =3D "vcc_sdio"; > regulator-type =3D "voltage"; > + regulator-always-on; > regulator-min-microvolt =3D <1800000>; > regulator-max-microvolt =3D <3300000>; > - regulator-always-on; > vin-supply =3D <&vcc_sys>; > }; > =20 > vcc_host1_5v: vcc_otg_5v: regulator-vcc-host1-5v { > compatible =3D "regulator-fixed"; > + regulator-name =3D "vcc_host1_5v"; > enable-active-high; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&usb20_host_drv>; > - regulator-name =3D "vcc_host1_5v"; > regulator-always-on; > + regulator-min-microvolt =3D <5000000>; > + regulator-max-microvolt =3D <5000000>; > vin-supply =3D <&vcc_sys>; > }; ... and was the case here? Cheers, Diederik > =20 > + /* sourced from usb input through 3A fuse */ > vcc_sys: regulator-vcc-sys { > compatible =3D "regulator-fixed"; > regulator-name =3D "vcc_sys"; > @@ -73,7 +77,7 @@ vcc_sys: regulator-vcc-sys { > regulator-boot-on; > regulator-min-microvolt =3D <5000000>; > regulator-max-microvolt =3D <5000000>; > - vin-supply =3D <&dc_12v>; > + vin-supply =3D <&dc_5v>; > }; > =20 > vcc_phy: regulator-vcc-phy { > @@ -81,6 +85,9 @@ vcc_phy: regulator-vcc-phy { > regulator-name =3D "vcc_phy"; > regulator-always-on; > regulator-boot-on; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + vin-supply =3D <&vcc_io>; > }; > =20 > leds { --768b44e4608be46521de5d39885a4e035e23bf1739a34b0bd3d7b81b3cbe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ1gmeQAKCRDXblvOeH7b bmMBAQDzQzO1G+w5qzoBp5aUjpUNIUQhGVvq8MR3l/ziGJqI8gEAyBZ7Pt2t9Uc1 WSOu5/T6z7u4uJ8LYn9q97mYE7UlTg0= =qRUc -----END PGP SIGNATURE----- --768b44e4608be46521de5d39885a4e035e23bf1739a34b0bd3d7b81b3cbe-- --===============3227075082022791583== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============3227075082022791583==--