From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Kever Yang" <kever.yang@rock-chips.com>, <heiko@sntech.de>
Cc: <linux-rockchip@lists.infradead.org>,
"Conor Dooley" <conor.dooley@microchip.com>,
<devicetree@vger.kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Rob Herring" <robh@kernel.org>,
"Dragan Simic" <dsimic@manjaro.org>,
"Jonas Karlman" <jonas@kwiboo.se>, <linux-kernel@vger.kernel.org>,
"Tim Lunn" <tim@feathertop.org>,
<linux-arm-kernel@lists.infradead.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Jianfeng Liu" <liujianfeng1994@gmail.com>,
"Andy Yan" <andyshrk@163.com>
Subject: Re: [PATCH v2 5/7] dt-bindings: arm: rockchip: Sort for rk3568 evb
Date: Fri, 20 Dec 2024 16:08:54 +0100 [thread overview]
Message-ID: <D6GMFFSALGMQ.3GQ1PUD6L2TV8@cknow.org> (raw)
In-Reply-To: <20241220101551.3505917-6-kever.yang@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 2307 bytes --]
Hi Kever,
On Fri Dec 20, 2024 at 11:15 AM CET, Kever Yang wrote:
> The info for rk3568 should before rk3588.
Indeed, so thanks for this patch.
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>
> Changes in v2:
> - collect acked-by tag
>
> .../devicetree/bindings/arm/rockchip.yaml | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12923..45ee4bf7c80c 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1006,6 +1006,16 @@ properties:
> - const: rockchip,rk3399-sapphire-excavator
> - const: rockchip,rk3399
>
> + - description: Rockchip RK3566 BOX Evaluation Demo board
> + items:
> + - const: rockchip,rk3566-box-demo
> + - const: rockchip,rk3566
> +
> + - description: Rockchip RK3568 Evaluation board
> + items:
> + - const: rockchip,rk3568-evb1-v10
> + - const: rockchip,rk3568
> +
> - description: Rockchip RK3588 Evaluation board
> items:
> - const: rockchip,rk3588-evb1-v10
> @@ -1099,16 +1109,6 @@ properties:
> - const: zkmagic,a95x-z2
> - const: rockchip,rk3318
>
> - - description: Rockchip RK3566 BOX Evaluation Demo board
> - items:
> - - const: rockchip,rk3566-box-demo
> - - const: rockchip,rk3566
> -
> - - description: Rockchip RK3568 Evaluation board
> - items:
> - - const: rockchip,rk3568-evb1-v10
> - - const: rockchip,rk3568
> -
While you're fixing the sorting order of these 2 Rockchip items, it
would be great if "Sinovoip RK3308 Banana Pi P2 Pro", "Sinovoip RK3568
Banana Pi R2 Pro" and "Sonoff iHost Smart Home Hub" could also be moved
into their correctly sorted position. A quick scan seems to indicate
that all the other items are properly sorted.
Cheers,
Diederik
> - description: Sinovoip RK3308 Banana Pi P2 Pro
> items:
> - const: sinovoip,rk3308-bpi-p2pro
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-12-20 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 10:15 [PATCH v2 0/7] Rockchip: add Rockchip rk3576 EVB1 board Kever Yang
2024-12-20 10:15 ` [PATCH v2 1/7] dts: arm64: rockchip: Add rk3576 naneng combphy nodes Kever Yang
2024-12-20 10:15 ` [PATCH v2 2/7] dt-bindings: PCI: dwc: rockchip: Add rk3576 support Kever Yang
2024-12-20 11:43 ` Rob Herring (Arm)
2024-12-22 6:39 ` Krzysztof Kozlowski
2024-12-20 10:15 ` [PATCH v2 3/7] dts: arm64: rockchip: Add rk3576 pcie nodes Kever Yang
2024-12-22 6:38 ` Krzysztof Kozlowski
2024-12-23 10:49 ` Kever Yang
2024-12-23 12:38 ` Heiko Stübner
2024-12-20 10:15 ` [PATCH v2 4/7] arm64: dts: rockchip: add usb related nodes for rk3576 Kever Yang
2024-12-20 10:15 ` [PATCH v2 5/7] dt-bindings: arm: rockchip: Sort for rk3568 evb Kever Yang
2024-12-20 15:08 ` Diederik de Haas [this message]
2024-12-20 10:15 ` [PATCH v2 6/7] dt-bindings: arm: rockchip: Add rk3576 evb1 board Kever Yang
2024-12-20 10:15 ` [PATCH v2 7/7] arm64: dts: " Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6GMFFSALGMQ.3GQ1PUD6L2TV8@cknow.org \
--to=didi.debian@cknow.org \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh@kernel.org \
--cc=tim@feathertop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox