Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Salvatore Bonaccorso" <carnil@debian.org>
Cc: "Valentin Kleibel" <valentin@vrvis.at>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Chukun Pan" <amadeus@jmu.edu.cn>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Jianfeng Liu" <liujianfeng1994@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.se>
Subject: Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT
Date: Fri, 21 Feb 2025 09:57:14 +0100	[thread overview]
Message-ID: <D7XZZ70KM9NT.14VSJDFUTH0H5@cknow.org> (raw)
In-Reply-To: <Z7gosm7PJMR0zCg4@eldamar.lan>

[-- Attachment #1.1: Type: text/plain, Size: 1786 bytes --]

On Fri Feb 21, 2025 at 8:18 AM CET, Salvatore Bonaccorso wrote:
> On Tue, Feb 18, 2025 at 12:45:34PM +0100, Diederik de Haas wrote:
>> On Tue Feb 11, 2025 at 2:03 PM CET, Valentin Kleibel wrote:
>> >>> Chukun Pan (1):
>> >>>    phy: rockchip: naneng-combphy: compatible reset with old DT
>> >> 
>> >> Applied, thanks!
>> >> 
>> >> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
>> >>        commit: bff68d44135ce6714107e2f72069a79476c8073d
>> >
>> > Thanks for your work!
>> > We found your patch after NVMes stopped working on a rock 3A with newer 
>> > kernels and successfully applied it to kernel 6.1.128 (currently in debian).
>> 
>> FTR: I've reported it in Debian here: https://bugs.debian.org/1098250
>> 
>> I confirmed it (also) broke on kernel 6.12.8-1.
>
> FWIW, we have several users in Debian reporting the problem, so if it
> can be applied to mainline and then flow down to one of the next round
> of stable series down to 6.1.y that would be highly appreicated.
>
> Diederik, if you were able to test the fix, you might contribute a
> Tested-by (although as I undestsand its not strictly needed at this
> point as commit should be on way to mainline and stable series)?

AFAIK a Tested-by could increase the chances of the maintainer accepting
the patch, but that has already happened (commit date: 2025-02-04).
The patch was already verified to fix the problem before submission:
https://lore.kernel.org/all/20250103171109.2726312-1-liujianfeng1994@gmail.com/

So AFAICT another Tested-by would either have no effect or a delaying
effect (adding it would change a bunch of commit IDs probably triggering
various CIs to run again).
I'm not aware of anything (else) I could do wrt this patch.

Cheers,
  Diederik

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip