Re: [PATCH] arm64: dts: rockchip: Update eMMC for NanoPi R5 series

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Peter Robinson" <pbrobinson@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Vasily Khoruzhick" <anarsoul@gmail.com>,
	"Tianling Shen" <cnsztl@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>
Cc: "Dragan Simic" <dsimic@manjaro.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Update eMMC for NanoPi R5 series
Date: Thu, 08 May 2025 13:19:46 +0200	[thread overview]
Message-ID: <D9QQLQ6MVUY4.13OOYJ1B1NWQC@cknow.org> (raw)
In-Reply-To: <20250506222531.625157-1-pbrobinson@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2694 bytes --]

On Wed May 7, 2025 at 12:25 AM CEST, Peter Robinson wrote:
> Add the 3.3v and 1.8v regulators that are connected to
> the eMMC on the R5 series devices, as well as adding the
> eMMC data strobe, and enable eMMC HS200 mode as the
> Foresee FEMDNN0xxG-A3A55 modules support it.

Foresee eMMC FEMDNN032G-A3A55 datasheet version 1.2 dd 2021-05-17
mentions on page 4 that it supports HS400 and HS200.
It also mentions in paragraph 5.2 "Power Consumption" on page 6 that
``Vcc`` uses 3.3V and ``Vccq`` uses 1.8V.

In chapter 6 "Pin Assignment" on page 7 we can see the following pin
assignments in "FBGA153 - Ball Array":

Vcc: E6+F5+J10+K9
Vccq: C6+M4+N4+P3+P5
Data Strobe(DS): H5

In the NanoPi R5S schematic version 2204 on page 23 we can see
eMMC_153FBGA/U9501 described.

Pins E6+F5+J10+K9 are all labeled ``VDDF`` and those are connected to
``VCC3V3_FLASH`` which is connected to ``VCC_3V3``.

Pins C6+M4+N4+P3+P5 are all labeled ``VDD`` and those are connected to
``VCCIO_FLASH`` which is connected to ``VCC_1V8``.

Pin H5 is labeled ``Data Strobe`` and is connected to
``eMMC_DATA_STROBE/FLASH_CLE`` which is connected to GPIO1_C6 which
corresponds to ``emmc_datastrobe`` in ``rk3568-pinctrl.dtsi``.

In the NanoPi R5C schematic version 2209 on page 22 we see the same pins
labeled ``VDDF`` and also for ``VDD``, but here they are (directly)
connected to ``VCC_3V3`` and ``VCC_1V8`` respectively.

> Fixes: c8ec73b05a95d ("arm64: dts: rockchip: create common dtsi for NanoPi R5 series")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>
> I had reports from some Fedora users that their eMMC didn't work
> on the R5C and this fixes it, the schematic of the eMMC is the
> same across all of the R5 series of devices.
>
>  arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi
> index 00c479aa18711..a28b4af10d13a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi
> @@ -486,9 +486,12 @@ &saradc {
>  &sdhci {
>  	bus-width = <8>;
>  	max-frequency = <200000000>;
> +	mmc-hs200-1_8v;
>  	non-removable;
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>;
> +	pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
> +	vmmc-supply = <&vcc_3v3>;
> +	vqmmc-supply = <&vcc_1v8>;

The above is correctly describe in the dtsi file, so

Reviewed-by: Diederik de Haas <didi.debian@cknow.org>

>  	status = "okay";
>  };
>  

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip