Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Andy Yan" <andyshrk@163.com>
Cc: "Piotr Zalewski" <pZ010001011111@proton.me>, <hjc@rock-chips.com>,
	<heiko@sntech.de>, <andy.yan@rock-chips.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
	"Dang Huynh" <danct12@riseup.net>,
	<dri-devel@lists.freedesktop.org>,
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH drm-misc-next] rockchip/drm: vop2: don't check color_mgmt_changed in atomic_enable
Date: Thu, 12 Jun 2025 10:33:18 +0200	[thread overview]
Message-ID: <DAKEZCDSGTEU.3M0D171ZZS8JE@cknow.org> (raw)
In-Reply-To: <562b38e5.a496.1975f09f983.Coremail.andyshrk@163.com>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1027 bytes --]

Hi Andy,

On Wed Jun 11, 2025 at 2:49 PM CEST, Andy Yan wrote:
> The root case for the problem is now clear。

\o/

> ...
>
> Actually, there is another question. I still haven't figured out why
> this problem doesn't occur when compiling rockchipdrm=y . 

Thus far I had compiled all my kernels with this:

```sh
make clean
cp ../config-6.14-arm64-cknow .config
scripts/config --enable LOCALVERSION_AUTO
scripts/config --enable DEBUG_INFO_NONE
scripts/config --disable DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT
make oldconfig
time make -j `nproc` bindeb-pkg
```

And with ``make oldconfig`` I accepted all the defaults (during
git bisect I did say 'y' to a new Rockchip related setting)

Wanting to see ``DRM_ROCKCHIP=y`` for myself, I added

```sh
scripts/config --enable DRM_ROCKCHIP
scripts/config --enable DRM
```

before ``make oldconfig`` and built a new kernel.
I can confirm I'm seeing it work now too.
Attached you'll find the ``.config`` diff between the 2 builds.

HTH,
  Diederik

[-- Attachment #1.1.2: kernel-config-diff-with-drm_rockchip-y.diff --]
[-- Type: text/x-patch, Size: 2624 bytes --]

root@pt2-scmi:/boot# diff -u config-6.14.0-rc1-00001-gfbe17d9b77b0 config-6.14.0-rc1-00002-gbc85fa3dec68

--- config-6.14.0-rc1-00001-gfbe17d9b77b0       2025-06-09 11:47:09.000000000 +0200
+++ config-6.14.0-rc1-00002-gbc85fa3dec68       2025-06-11 18:43:24.000000000 +0200
@@ -6193,13 +6193,12 @@
 CONFIG_RC_ATI_REMOTE=m
 CONFIG_RC_LOOPBACK=m
 # CONFIG_RC_XBOX_DVD is not set
-CONFIG_CEC_CORE=m
+CONFIG_CEC_CORE=y
 CONFIG_CEC_NOTIFIER=y
 
 #
 # CEC support
 #
-CONFIG_MEDIA_CEC_RC=y
 CONFIG_MEDIA_CEC_SUPPORT=y
 # CONFIG_CEC_CH7322 is not set
 # CONFIG_CEC_CROS_EC is not set
@@ -7185,16 +7184,16 @@
 CONFIG_TEGRA_HOST1X_CONTEXT_BUS=y
 CONFIG_TEGRA_HOST1X=m
 CONFIG_TEGRA_HOST1X_FIREWALL=y
-CONFIG_DRM=m
+CONFIG_DRM=y
 CONFIG_DRM_MIPI_DSI=y
 # CONFIG_DRM_DEBUG_MM is not set
-CONFIG_DRM_KMS_HELPER=m
+CONFIG_DRM_KMS_HELPER=y
 # CONFIG_DRM_PANIC is not set
 # CONFIG_DRM_DEBUG_DP_MST_TOPOLOGY_REFS is not set
 # CONFIG_DRM_DEBUG_MODESET_LOCK is not set
 CONFIG_DRM_CLIENT=y
-CONFIG_DRM_CLIENT_LIB=m
-CONFIG_DRM_CLIENT_SELECTION=m
+CONFIG_DRM_CLIENT_LIB=y
+CONFIG_DRM_CLIENT_SELECTION=y
 CONFIG_DRM_CLIENT_SETUP=y
 
 #
@@ -7210,7 +7209,7 @@
 
 CONFIG_DRM_LOAD_EDID_FIRMWARE=y
 CONFIG_DRM_DISPLAY_DP_AUX_BUS=m
-CONFIG_DRM_DISPLAY_HELPER=m
+CONFIG_DRM_DISPLAY_HELPER=y
 CONFIG_DRM_BRIDGE_CONNECTOR=y
 # CONFIG_DRM_DISPLAY_DP_AUX_CEC is not set
 CONFIG_DRM_DISPLAY_DP_AUX_CHARDEV=y
@@ -7226,7 +7225,7 @@
 CONFIG_DRM_BUDDY=m
 CONFIG_DRM_VRAM_HELPER=m
 CONFIG_DRM_TTM_HELPER=m
-CONFIG_DRM_GEM_DMA_HELPER=m
+CONFIG_DRM_GEM_DMA_HELPER=y
 CONFIG_DRM_GEM_SHMEM_HELPER=m
 CONFIG_DRM_SUBALLOC_HELPER=m
 CONFIG_DRM_SCHED=m
@@ -7317,7 +7316,7 @@
 CONFIG_DRM_VGEM=m
 # CONFIG_DRM_VKMS is not set
 # CONFIG_DRM_EXYNOS is not set
-CONFIG_DRM_ROCKCHIP=m
+CONFIG_DRM_ROCKCHIP=y
 CONFIG_ROCKCHIP_VOP=y
 CONFIG_ROCKCHIP_VOP2=y
 CONFIG_ROCKCHIP_ANALOGIX_DP=y
@@ -7520,7 +7519,7 @@
 # CONFIG_DRM_TI_TPD12S015 is not set
 CONFIG_DRM_ANALOGIX_ANX6345=m
 # CONFIG_DRM_ANALOGIX_ANX78XX is not set
-CONFIG_DRM_ANALOGIX_DP=m
+CONFIG_DRM_ANALOGIX_DP=y
 CONFIG_DRM_ANALOGIX_ANX7625=m
 CONFIG_DRM_I2C_ADV7511=m
 CONFIG_DRM_I2C_ADV7511_AUDIO=y
@@ -7535,13 +7534,13 @@
 # CONFIG_DRM_IMX8QXP_PIXEL_COMBINER is not set
 # CONFIG_DRM_IMX8QXP_PIXEL_LINK_TO_DPI is not set
 # CONFIG_DRM_IMX93_MIPI_DSI is not set
-CONFIG_DRM_DW_HDMI=m
+CONFIG_DRM_DW_HDMI=y
 # CONFIG_DRM_DW_HDMI_AHB_AUDIO is not set
 CONFIG_DRM_DW_HDMI_I2S_AUDIO=m
 # CONFIG_DRM_DW_HDMI_GP_AUDIO is not set
 CONFIG_DRM_DW_HDMI_CEC=m
-CONFIG_DRM_DW_HDMI_QP=m
-CONFIG_DRM_DW_MIPI_DSI=m
+CONFIG_DRM_DW_HDMI_QP=y
+CONFIG_DRM_DW_MIPI_DSI=y
 # end of Display Interface Bridges
 
 CONFIG_DRM_IMX_DCSS=m

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
