From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6049C83F03 for ; Wed, 9 Jul 2025 14:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:References:To:From:Subject:Cc:Message-Id:Date:Mime-Version: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3YVfvk7Sr4iQzhHYOX/kTwslUiDINBtdf2tm29W02/I=; b=KDd5fztuAQIqPqzhgAE9ZyRU8D uxLszym9/SYkZNojmAVQBnPgk76UEawPSFtnBZZkTZYtbjEWNstkxOCCRN2lTGvGPZyuyaXzzIdfM cf6NrOyqwk7028LZE9Soi8mx7WCe2VvU/3Gm2B3l4FZMg5NahAuUSj0Eg4gUK+V9Fpvz9bCg0X0qE t7ZlEmuB4ke38fsodytu9AGcSn2bFIWHTobuck+BcTXHj/Z/3B2X7REmlpwVS7YM3bWrdAfUqJup5 i588BmO18rNNBhCFl3Xm8emtrEP80zHeFif2RDHfsrw+7sWEQsfilhZyl7TN5pGUc/yi4blqQEpWd GIprxnsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZVTu-00000008ucN-3e3p; Wed, 09 Jul 2025 14:09:06 +0000 Received: from out-189.mta0.migadu.com ([2001:41d0:1004:224b::bd]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZSnv-00000008TNP-1uXm for linux-rockchip@lists.infradead.org; Wed, 09 Jul 2025 11:17:37 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1752059852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2jiUrJWIjrS/zl54Lua+tp5RGUjRBoaPMIxbNmfvQnk=; b=EZug0f5S+/AFz3Oz/SwVdCwV/oLCi9n3Ho1yrquCajDl1sjiNb71yHqETQh7MqlOSf2uoz psA3PKH5qYO+j+uDUSm0vloPFdNuC00n9oAK0Mf69vh9B9sD9XC9w21QHNRnGjRuDXqADX XZH7dniVfMA7lFA5MMj+d90SH8UWusVxqKBQSOBxyxq7txnToUjO9mINyjmOiZHISkHr2u LTDneFcGyq/7sBEViNnZsSPCsIMXNTRSAvwUsvGliPdu3kHee81sCLMbUJHN3df98ak4Uf KTL+Yiyt0S0wB2819QUPuNkL1Mtj3mg45N4jemDAPidBTxICYrtikgmOrm8npQ== Date: Wed, 09 Jul 2025 13:17:23 +0200 Message-Id: Cc: , , , Subject: Re: [PATCH] arm64: dts: rockchip: Add reset button to NanoPi R5S X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Krzysztof Kozlowski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" References: <20250709105715.119771-1-didi.debian@cknow.org> <649824ea-a420-437e-ace1-2f079235c604@kernel.org> In-Reply-To: <649824ea-a420-437e-ace1-2f079235c604@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250709_041736_190409_673D5786 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7752085458327989071==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============7752085458327989071== Content-Type: multipart/signed; boundary=a15b73511b44a3a7249de8bd0c977f6d60b982377015c90af4dbb343db1a; micalg=pgp-sha512; protocol="application/pgp-signature" --a15b73511b44a3a7249de8bd0c977f6d60b982377015c90af4dbb343db1a Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Wed Jul 9, 2025 at 1:05 PM CEST, Krzysztof Kozlowski wrote: > On 09/07/2025 12:57, Diederik de Haas wrote: >> + gpio-keys { >> + compatible =3D "gpio-keys"; >> + pinctrl-0 =3D <&gpio4_a0_k1>; >> + pinctrl-names =3D "default"; >> + >> + button-reset { >> + debounce-interval =3D <50>; >> + gpios =3D <&gpio4 RK_PA0 GPIO_ACTIVE_LOW>; >> + label =3D "RESET"; >> + linux,code =3D ; >> + }; >> + }; >> + >> gpio-leds { >> compatible =3D "gpio-leds"; >> pinctrl-names =3D "default"; >> @@ -127,6 +140,12 @@ eth_phy0_reset_pin: eth-phy0-reset-pin { >> }; >> }; >> =20 >> + gpio-keys { >> + gpio4_a0_k1: gpio4-a0-k1 { > > Are you sure that this passes checks? I did the following: ```sh export PATH=3D~/dev/kernel.org/dt-schema-venv/bin/:$PATH CROSS_COMPILE=3Daa= rch64-linux-gnu- ARCH=3Darm64 make distclean make debarm64_defconfig make CHECK_DTBS=3Dy W=3D1 rockchip/rk3568-nanopi-r5s.dtb ``` And it did not report any issues. Then booted up my NanoPi R5S and verified that with the updated dtb the reset button worked. If it's about the 'weird' name/label, it is what is used in the schematic document I have and I asked Heiko (on IRC) if using ``reset_button_pin: gpio4-a0-k1`` would not be better. That would make it more descriptive while also having the schematic traceability in it. The answer was no, use the form I used in this patch. Am I missing checks I should've done as well? Cheers, Diederik --a15b73511b44a3a7249de8bd0c977f6d60b982377015c90af4dbb343db1a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaG5PxgAKCRDXblvOeH7b bi3IAP0QZ6nrHeJEorK5zsrkL55Nlul5jDIYPBwehpDyDLT8BgD+JuPieM/qOX2V t77WC+GEezyPZaeos/wdCAlTkGS+OA8= =okS4 -----END PGP SIGNATURE----- --a15b73511b44a3a7249de8bd0c977f6d60b982377015c90af4dbb343db1a-- --===============7752085458327989071== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============7752085458327989071==--