From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B05ADCAC592 for ; Thu, 11 Sep 2025 09:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:References:Subject:Cc:To:From:Message-Id:Date:Mime-Version: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PlrM0+e7jL3vuYoie3Cxb+Y21WGoQ3uDe1otphPmSUs=; b=EP3ePyYTIQB2an6ziONOtsoB2L 6Qcorams2tKcMw24dUCJmexfi9P009o2D3KnyAtXtF/FlmFBDBTt9Ln49I2/S8JNRn96XrSbe2mdG EzjoFR13Y1G+auPn06qpM9et+MZrd3UuBWUUFTFktL3F/1jTATn+fFkw0MHflFIdw4XKI/fT+zgQe cC9OuiEtRPmS1ffcPz8r1KYYALn93t7iCltqiy8pkGZIQ6PJELclDRUaOOlCaojl30yGEA2Ac7Cz7 BQtDWt/BpkNoGnbPW6w3KsmWErirrZbRbi3tbc/Fkirv5F9GMpjzS43LuEllIuKoFJCIPPRTG1EWd K2X//2pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwdB9-00000001yNL-0Pdq; Thu, 11 Sep 2025 09:01:19 +0000 Received: from out-178.mta1.migadu.com ([2001:41d0:203:375::b2]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uwdB7-00000001yKx-0GXX for linux-rockchip@lists.infradead.org; Thu, 11 Sep 2025 09:01:18 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1757581264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sel27oZgcA+4qs92Ns785z7hsDLS/ChrGwuIP1OX4QY=; b=RIVDSn+hVXAKKajO3BRUnX+PyZI/AhKE0Wn5Etb5gKNYHCOfcMIm2lXptzKPu5a13C8hqi dTzFniMW80cSeplBesZEyQGxWOkYxU90JGNGZlx+n5/rx3fjS866EjUs48bRz15GiymiwQ 9GBNt8cBZyfIMIVUsZZJ1KhohDTSXlnBhdldGJaop/ST6Z4AOs7x1c39BgtYxLHS7jrAbs 8g4/WVpaJAJj4cswJCf636dAspMsev8cp1tPn8Y00ZI/YhWeUdEGoPcWVohRk5TW3bESc+ 53r0AmyXBLDBJorq9A+l9swYRAiEEp7gH7KDOCvVsNfXqgIj/GivbNrq+kTUhQ== Date: Thu, 11 Sep 2025 11:00:54 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Christian Hewitt" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: "Alex Bee" , , , , Subject: Re: [PATCH v3 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 References: <20250906120810.1833016-1-christianshewitt@gmail.com> In-Reply-To: <20250906120810.1833016-1-christianshewitt@gmail.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250911_020117_240433_3AC6A1F3 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8401430497166327980==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============8401430497166327980== Content-Type: multipart/signed; boundary=ae5433376ac9f3e1826a9aad5813272fffe73f438ca790723a238b2ba171; micalg=pgp-sha512; protocol="application/pgp-signature" --ae5433376ac9f3e1826a9aad5813272fffe73f438ca790723a238b2ba171 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sat Sep 6, 2025 at 2:08 PM CEST, Christian Hewitt wrote: > From: Alex Bee > > Add GPU powerdomain, opp-table, and cooling map nodes for the Mali > GPU on the RK3328 SoC. Opp-table frequencies are sourced from the > Rockchip Linux v4.4 vendor kernel while voltages have been derived > from practical use and support work: keeping voltage above 1075mV > and disabling the 500MHz opp-point avoids instability and crashes. > > Signed-off-by: Alex Bee > Signed-off-by: Christian Hewitt Now that the 'other' issue with power domains has been resolved, or at least localized, I feel (more) comfortable giving my Tested-by: Diederik de Haas # Rock64 Cheers, Diederik > --- > Changes since v2: > - Revert to gpu_opp_table but retain opp-table-gpu $nodename > Changes since v1: > - Use opp_table_gpu not gpu_opp_table to fix dtb schema warnings > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 39 +++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/d= ts/rockchip/rk3328.dtsi > index 6438c969f9d7..610c1c27b798 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -331,6 +331,11 @@ power: power-controller { > #address-cells =3D <1>; > #size-cells =3D <0>; > =20 > + power-domain@RK3328_PD_GPU { > + reg =3D ; > + clocks =3D <&cru ACLK_GPU>; > + #power-domain-cells =3D <0>; > + }; > power-domain@RK3328_PD_HEVC { > reg =3D ; > clocks =3D <&cru SCLK_VENC_CORE>; > @@ -570,9 +575,13 @@ map0 { > <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > contribution =3D <4096>; > }; > + map1 { > + trip =3D <&target>; > + cooling-device =3D <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + contribution =3D <4096>; > + }; > }; > }; > - > }; > =20 > tsadc: tsadc@ff250000 { > @@ -651,7 +660,35 @@ gpu: gpu@ff300000 { > "ppmmu1"; > clocks =3D <&cru ACLK_GPU>, <&cru ACLK_GPU>; > clock-names =3D "bus", "core"; > + operating-points-v2 =3D <&gpu_opp_table>; > + power-domains =3D <&power RK3328_PD_GPU>; > resets =3D <&cru SRST_GPU_A>; > + #cooling-cells =3D <2>; > + }; > + > + gpu_opp_table: opp-table-gpu { > + compatible =3D "operating-points-v2"; > + opp-200000000 { > + opp-hz =3D /bits/ 64 <200000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-300000000 { > + opp-hz =3D /bits/ 64 <300000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-400000000 { > + opp-hz =3D /bits/ 64 <400000000>; > + opp-microvolt =3D <1075000>; > + }; > + > + opp-500000000 { > + /* causes stability issues */ > + opp-hz =3D /bits/ 64 <500000000>; > + opp-microvolt =3D <1150000>; > + status =3D "disabled"; > + }; > }; > =20 > h265e_mmu: iommu@ff330200 { --ae5433376ac9f3e1826a9aad5813272fffe73f438ca790723a238b2ba171 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaMKPyQAKCRDXblvOeH7b bnvvAP9cDJ5evO0m4pNc3VzMtFadq913C7DWR5qrTp1cVAzeMAD/ZA+eArhOyXVx S3TR4Ha5ypA3l+htGbzr3UZ2YtgszQA= =K9LX -----END PGP SIGNATURE----- --ae5433376ac9f3e1826a9aad5813272fffe73f438ca790723a238b2ba171-- --===============8401430497166327980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============8401430497166327980==--