On Sat Sep 6, 2025 at 2:08 PM CEST, Christian Hewitt wrote:
> From: Alex Bee <knaerzche@gmail.com>
>
> Add a gpu node to the rock64 board to enable the Mali GPU and
> move the existing node from roc-pc to the shared roc dtsi to
> enable it also for the roc-cc board.
>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>

Now that the 'other' issue with power domains has been resolved, or at
least localized, I feel (more) comfortable giving my

Tested-by: Diederik de Haas <didi.debian@cknow.org>  # Rock64

Cheers,
  Diederik

> ---
> Changes since v2:
> - No changes
> Changes since v1:
> - No changes
>
>  arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts | 4 ----
>  arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi   | 4 ++++
>  arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 4 ++++
>  3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
> index 329d03172433..c0b7b98ff788 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
> @@ -44,10 +44,6 @@ &codec {
>  	mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
>  };
>  
> -&gpu {
> -	mali-supply = <&vdd_logic>;
> -};
> -
>  &pinctrl {
>  	ir {
>  		ir_int: ir-int {
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
> index b5bd5e7d5748..7eef6f7f108f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
> @@ -160,6 +160,10 @@ &gmac2io {
>  	status = "okay";
>  };
>  
> +&gpu {
> +	mali-supply = <&vdd_logic>;
> +};
> +
>  &hdmi {
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 5367e5fa9232..592fd8ca21df 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -152,6 +152,10 @@ &gmac2io {
>  	status = "okay";
>  };
>  
> +&gpu {
> +	mali-supply = <&vdd_logic>;
> +};
> +
>  &hdmi {
>  	avdd-0v9-supply = <&vdd_10>;
>  	avdd-1v8-supply = <&vcc_18>;