Re: [PATCH v3 0/2] arm64: dts: rockchip: Add vdpu 381 and 383 nodes

From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Detlev Casanova" <detlev.casanova@collabora.com>,
	<linux-kernel@vger.kernel.org>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Chukun Pan" <amadeus@jmu.edu.cn>,
	"Alexander Shiyan" <eagle.alexander923@gmail.com>,
	<kernel@collabora.com>, "Dragan Simic" <dsimic@manjaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	<linux-rockchip@lists.infradead.org>,
	<devicetree@vger.kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Damon Ding" <damon.ding@rock-chips.com>,
	"Chris Morgan" <macromorgan@hotmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	"Patrick Wildt" <patrick@blueri.se>,
	"Alexey Charkov" <alchark@gmail.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
	"Tomeu Vizoso" <tomeu@tomeuvizoso.net>
Subject: Re: [PATCH v3 0/2] arm64: dts: rockchip: Add vdpu 381 and 383 nodes
Date: Fri, 24 Oct 2025 21:20:45 +0200	[thread overview]
Message-ID: <DDQSO2HR1BFU.2JONNHRBR0LR5@cknow-tech.com> (raw)
In-Reply-To: <20251020212009.8852-1-detlev.casanova@collabora.com>

Hi Detlev,

On Mon Oct 20, 2025 at 11:20 PM CEST, Detlev Casanova wrote:
> Add the nodes for vdpu 381 and 383, respectively RK3588 and RK3576.
> To keep compatibility with older variants, the reg ranges order is not
> in register order so that the function reg range is kept first.

This is a great comment, which I'd have preferred to have seen in the
commit messages themselves.

Especially since I'm getting DTB validation warnings:

  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb
arch/arm64/boot/dts/rockchip/rk3576.dtsi:1292.30-1314.5: Warning (simple_bus_reg):
/soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dtb
arch/arm64/boot/dts/rockchip/rk3576.dtsi:1292.30-1314.5: Warning (simple_bus_reg):
/soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"

For some reason I'm not getting that for rk3588, which I need to
investigate further. Technically, I ran my DTB validation script on your
'add-vdpu381-and-383-to-rkvdec-v3-on-next' branch, but I don't see how
that would/could change the outcome.

My validation script does essentially this:
``make CHECK_DTBS=y W=1 $(get_my_dtbs)``

('get_my_dtbs' returns a list of dtb files I want to check)

So it looks like the DTB validation tool is not happy that the
reg ranges are not sorted in 'proper' order.

Note that the ``W=1`` is essential to see the warning, it does not show
up when ``W=0`` is used.
I'll leave it up to you and the maintainers to judge whether this is
problematic or not, but wanted to mention it.

Cheers,
  Diederik

> Also adds the corresponding iommu nodes.
>
> Note that on RK3588, both cores are added as it represents the hardware,
> but the driver, later will only register the first one.
>
> Regards,
> Detlev.
>
> Changes since v2:
>  - Set the correct IRQ number for the second rk3588 core
>
> Changes since v1:
>  - Set node name to match first reg range
>
> Detlev Casanova (2):
>   arm64: dts: rockchip: Add the vdpu381 Video Decoders on RK3588
>   arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576
>
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 36 +++++++++
>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 74 +++++++++++++++++++
>  2 files changed, 110 insertions(+)

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip