From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ABACCCFA18 for ; Tue, 11 Nov 2025 13:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JTZHGOtKDsHAjXQajJ2qt58KYRN+eW1hLmenYrsjoJE=; b=t91tq2T4EuqrUC Vdbq6PabJEtqAKAvfMpOMZnLFyyQh4dJ+/95P8ml1ubMpdLOOKNf/vgAmG3y6nlkvowc+isNCUvV5 mSXsAuG7dnD92TtGTRX6CM6E/JMvT4QWhjTD1He/yNWsNJZsWGuXmFMKu7eRZeGG3ikZgJ8bFBf9g rrysL28to5xlSi2ksFUkXlc/dbOBDeJSeoT+qS71SI9u58dpA1gBHZI5GHX2hxOaFK4KH3kp2gdWf 0OrSbwmFvA3C8OKRG4hWIOUAajXo5ieMt4mQNpD5+aJiimfNSyyM+LtcZyjfWFKIOEle4spyX7v8H 3yn7pHC+59PWTCw/IgPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIo60-00000007E42-0ln5; Tue, 11 Nov 2025 13:07:40 +0000 Received: from out-181.mta0.migadu.com ([2001:41d0:1004:224b::b5]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIo5w-00000007E2p-238y for linux-rockchip@lists.infradead.org; Tue, 11 Nov 2025 13:07:39 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1762866449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hp9j1SamJ8X7GVph6JpG3EZJam2gMiRDcakI0IBlJ0g=; b=O0vbCUVvvSCKSx+8Oo2TtZ3GndYBeySbL28Gm3Szor5oLFbeyKNRCHm0qnvLps7fgQhAdZ NwAQFLj8RkSvepyetwvGrVWnVMXoAZvr6B1eZpRdprzAw6R/hLSN0GW8aC6+blEXDszr+z 5wg9/ATGIfWUQtwdZkeC1OGceZR51ObH+d59FuDCSQDldjNeFKwrZxvbmxF1F/vW/cPqfG NP3vBbCPWqYEBFnaZCKDFdh10NEO+l+bgI54KH4OK6BK770k5BdjAgBo9RTtnk2AL7dLsp 5sy8T51w3hX1GhA+rX1tGMVSxnJS73tI2wkS8l14X+aQ8Eqa+Dq1bw7doBnlfg== Date: Tue, 11 Nov 2025 14:07:25 +0100 Message-Id: Subject: Re: [PATCH v2] arm64: dts: rockchip: Turn all LEDs on at boot for Radxa boards X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "FUKAUMI Naoki" , Cc: , , , , , , , , , , , , , , , , , , , , References: <20251111054112.55505-1-naoki@radxa.com> In-Reply-To: <20251111054112.55505-1-naoki@radxa.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251111_050737_412206_7CB8354C X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue Nov 11, 2025 at 6:41 AM CET, FUKAUMI Naoki wrote: > Radxa's boards turn all LEDs on at boot(loader), but some boards don't > have `default-state` property in Linux kernel tree but have it in > U-Boot tree instead[1]. > > This patch adds `default-state = "on"` for (almost) all LEDs (with a > few exceptions which should be "off" such as RGB LEDs on E25 and LAN/ > WAN LEDs on E20C/E52C). I'm missing the *why* these changes would be an improvement. Personally, for both 'heartbeat' and 'netdev' triggers, I want them to be off by default and once it gets a 'heartbeat' or a 'netdev' trigger, THEN I want the LED to be on/blinking. > Also, remove following redundant properties: > linux,default-trigger = "default-on"; // use default-state = "on" > default-state = "off"; // default is "off" > > [1] > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi#L10-12 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi#L11-17 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi#L11-13 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi#L10-12 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi#L14-16 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi#L7-24 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi#L11-13 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L11-13 That the *bootloader* turns them on, is fine by me as it signals the board has received power and the bootloader has started. I don't think that that automatically means that Linux must do the same. Not a Radxa board, but the PineTab2's keyboard LEDs are turned on. I find that useful wrt the bootloader, but (actually) annoying that it is on by default with Linux. When I want/need backlight on the keyboard, I'll turn it on myself. Now I need to turn it off in 90% of cases. My 0.02 > https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi#L10-12 > > Signed-off-by: FUKAUMI Naoki > --- > Changes in v2: > - Add more URLs for reference > - Reword commit message > --- > arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + > arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 ++- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + > arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + > arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + > arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 3 ++- > arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 3 ++- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + > arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- > 16 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > index 7a32972bc2496..c1e3098b9a7bc 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > @@ -35,7 +35,6 @@ green-led { > function = LED_FUNCTION_POWER; > gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; > label = "rockpis:green:power"; > - linux,default-trigger = "default-on"; > }; > > blue-led { > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > index a4bdd87d0729f..d3d6f34b66fb0 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts > @@ -59,6 +59,7 @@ leds { > > led-0 { > color = ; > + default-state = "on"; > gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts > index 962b8b231c960..a83ffbef22a7b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts > @@ -39,14 +39,15 @@ leds { > led-0 { > function = LED_FUNCTION_POWER; > color = ; > + default-state = "on"; > gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "default-on"; > }; > > /* USER_LED2 */ > led-1 { > function = LED_FUNCTION_STATUS; > color = ; > + default-state = "on"; > gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > index 046dbe3290178..ef434c23fe85c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > @@ -35,6 +35,7 @@ leds { > led-0 { > function = LED_FUNCTION_STATUS; > color = ; > + default-state = "on"; > gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts > index b324527561558..79d316a1d8495 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts > @@ -62,7 +62,6 @@ leds { > > led-lan { > color = ; > - default-state = "off"; > function = LED_FUNCTION_LAN; > gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "netdev"; > @@ -78,7 +77,6 @@ led-sys { > > led-wan { > color = ; > - default-state = "off"; > function = LED_FUNCTION_WAN; > gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "netdev"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts b/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts > index c03ae1dd34560..0b696d49b71fa 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts > @@ -45,7 +45,6 @@ led-1 { > default-state = "on"; > function = LED_FUNCTION_STATUS; > gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "default-on"; > }; > }; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts b/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts > index b5b253f04cdf5..9e7212b70e3f1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts > @@ -46,6 +46,7 @@ leds { > led-1 { > gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_LOW>; > color = ; > + default-state = "on"; > function = LED_FUNCTION_ACTIVITY; > linux,default-trigger = "heartbeat"; > pinctrl-names = "default"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > index 6224d72813e59..3ec108bcf89a1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > @@ -47,6 +47,7 @@ led-0 { > gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > function = LED_FUNCTION_HEARTBEAT; > color = ; > + default-state = "on"; > linux,default-trigger = "heartbeat"; > pinctrl-names = "default"; > pinctrl-0 = <&user_led2>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > index 729e38b9f620e..140582f8e1034 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > @@ -23,6 +23,7 @@ led_user: led-0 { > gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; > function = LED_FUNCTION_HEARTBEAT; > color = ; > + default-state = "on"; > linux,default-trigger = "heartbeat"; > pinctrl-names = "default"; > pinctrl-0 = <&led_user_en>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index 44cfdfeed6681..e6c18df0fa582 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -47,6 +47,7 @@ led_user: led-0 { > gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; > function = LED_FUNCTION_HEARTBEAT; > color = ; > + default-state = "on"; > linux,default-trigger = "heartbeat"; > pinctrl-names = "default"; > pinctrl-0 = <&led_user_en>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > index 9bc33422ced50..99d3a8be8f18c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > @@ -52,13 +52,14 @@ leds: leds { > > power-led { > color = ; > + default-state = "on"; > function = LED_FUNCTION_STATUS; > gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "default-on"; > }; > > user-led { > color = ; > + default-state = "on"; > function = LED_FUNCTION_HEARTBEAT; > gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > index 854c118418eb8..f737769d4a007 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts > @@ -71,7 +71,6 @@ leds-1 { > > led-1 { > color = ; > - default-state = "off"; > function = LED_FUNCTION_LAN; > linux,default-trigger = "netdev"; > pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>; > @@ -80,7 +79,6 @@ led-1 { > > led-2 { > color = ; > - default-state = "off"; > function = LED_FUNCTION_WAN; > linux,default-trigger = "netdev"; > pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts > index bc8140883de47..86477346c3f5a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts > @@ -88,11 +88,12 @@ gpio-leds { > pinctrl-0 = <&led_pins>; > > power-led1 { > + default-state = "on"; > gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "default-on"; > }; > > hdd-led2 { > + default-state = "on"; > gpios = <&gpio0 RK_PC0 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "disk-activity"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi > index e5c474e4d02a6..8c4a4270f9f93 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi > @@ -30,6 +30,7 @@ leds { > led_rgb_b { > function = LED_FUNCTION_STATUS; > color = ; > + default-state = "on"; > gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts > index 0dd90c744380b..87e9d4b86dad4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts > @@ -33,6 +33,7 @@ leds { > led_rgb_b { > function = LED_FUNCTION_STATUS; > color = ; > + default-state = "on"; > gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > index 19a08f7794e67..46c81e796b100 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > @@ -54,6 +54,7 @@ leds { > > io-led { > color = ; > + default-state = "on"; > function = LED_FUNCTION_STATUS; > gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > @@ -61,9 +62,9 @@ io-led { > > power-led { > color = ; > + default-state = "on"; > function = LED_FUNCTION_POWER; > gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "default-on"; > }; > }; > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip