From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5369D0D16E for ; Wed, 7 Jan 2026 19:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:Subject:Cc: To:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OeD/t4OS/YTYkzsF6vs6HutvzG4pZx1GAUQ210ZhEUU=; b=bhgGM7h/QnUaXQ swNhuoApVdF0yBejdSJQqh/PK5ER2FLpjfPv+trOEDq7H3WJctraq9LwkWm3+thP/yANHNQ8vfYE1 WaPMlKHuKyZame+4mnqF3eyw+9qQqTneiqB9SViRT+JDWepOPbba6l5NbC9kLjzBqEmaJz+2m/kqC Z6UDOkMBOJAxAW/GgF/qpr2VYl8dUyPR9rbDI2tYc/ifuV2Rb7ABmdH3WOR3Fxxwj07RHSaBVvhwC 1AzgS/V5zb8OKfb2qXKoe1e2JRdvxHCyylvKABnHZnkrc5RoTuBTUuMo3F5F4PPWBXcOkwknWWWe9 A07oHP91Wq0Q0YCqkeYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdZQi-0000000FZ19-3WvI; Wed, 07 Jan 2026 19:42:52 +0000 Received: from out-170.mta0.migadu.com ([91.218.175.170]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdZQf-0000000FZ0h-2SPJ for linux-rockchip@lists.infradead.org; Wed, 07 Jan 2026 19:42:51 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1767814965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xRTbJOKwkZYdpEZZY1w1lPpqDpzoRzUFJtgND5Kkiuo=; b=fOmNBsdQH3r8E465w1m0/hb7SvFn25larE0IcdL+p1lfYSACDzHb5rx1GxekuQfFPZg0n0 PacZa6h2gPIF1ZxVPSGMo8o3KJ81ZOAK7ScRXXRrHDVDxAHWgZZ7lhna3gLX7vG6u8LQHe n9x5hBQZKAYarCTcs5jQRetHJujtp+aT9f2s/kgAzJSQk3SXMH8zHAHYodXdgdHnwyNnPI ZXMyckftmevLGOp1LZw7xy5097Jl+7EQreUBjVLzWtZMsgLARl+VRDT1EE/5r0Ukd6+Njj FmOmX3riFNYkP6h1MYdGzFQEIDDUtOkIdavKfqFuoqTgm5TKFVwFKTzh61GQjQ== Date: Wed, 07 Jan 2026 20:42:37 +0100 Message-Id: To: "Cristian Ciocaltea" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Louis Chauvet" , "Haneen Mohammed" , "Melissa Wen" Cc: "Robert Mader" , , , , , , "Matt Roper" Subject: Re: [PATCH v4 0/4] Introduce BACKGROUND_COLOR DRM CRTC property X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> In-Reply-To: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260107_114250_066030_A7072847 X-CRM114-Status: GOOD ( 19.75 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri Dec 19, 2025 at 10:46 PM CET, Cristian Ciocaltea wrote: > Some display controllers can be hardware-configured to present non-black > colors for pixels which are not covered by any plane (or are exposed > through transparent regions of higher planes). > ... > The subsequent patches add background color support to VKMS and the VOP2 > display controller used in the RK3568, RK3576, and RK3588 Rockchip SoC > families. As previously reported against the v3, while I actually tested v4 ... Cristian provided a helper script which would show a test pattern and then iterate through setting Red, Green, Blue background color and then set it back to the original value. I first tested this on a Rock 5B (RK3588). Without this patch set, the background color was Black with every iteration. But with this patch set, I did see a Red, Green and Blue background color, after which it was set back to Black. diederik@rock5b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgcol-test-bash-user.log Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 Changing prop value to: 0xffff00000000ffff Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff Changing prop value to 0xffffffff00000000 Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 Changing prop value to 0xffff0000ffff0000 Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 Changing prop value to 0xffff00000000ffff Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff Changing prop value to: 0xffff000000000000 Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 I then did the same test on a Quartz64-B (RK3566) and that too showed a Red, Green and Blue background color and then was set back to Black. diederik@quartz64b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgcol-test-bash-user-q64b.log Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 Changing prop value to: 0xffff00000000ffff Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff Changing prop value to 0xffffffff00000000 Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 Changing prop value to 0xffff0000ffff0000 Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 Changing prop value to 0xffff00000000ffff Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff Changing prop value to: 0xffff000000000000 Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 So this patch set does what it is supposed to do, so feel free to add: Tested-by: Diederik de Haas Cheers, Diederik > > Signed-off-by: Cristian Ciocaltea > --- > Changes in v4: > - Switched to simple bit-shifting approach when performing the bpc > conversion in the vop2 driver, to avoid the expensive division since > we shouldn't be concerned anymore about the precision (Chaoyi) > - Rebased series onto latest drm-misc-next > - Link to v3: https://lore.kernel.org/r/20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com > > Changes in v3: > - Added new patches: > * uapi: Provide DIV_ROUND_CLOSEST() > * drm/vkms: Support setting custom background color > - Improved DRM_ARGB64_{PREP|GET}*() helpers by using a conversion ratio > for better color approximation when dealing with less than 16 bits of > precision > - Mentioned the IGT test in the cover letter while documenting the > validation results; also dropped references to the now useless > modetest wrapper script and its generated report > - Rebased series onto latest drm-misc-next > - Link to v2: https://lore.kernel.org/r/20251013-rk3588-bgcolor-v2-0-25cc3810ba8c@collabora.com > > Changes in v2: > - Improved uAPI consistency and readability by introducing > DRM_ARGB64_PREP*() and DRM_ARGB64_GET*() helper macros > - Updated several code comment sections > - Referenced the counterpart Weston support in the cover letter > - Rebased series onto v6.18-rc1 > - Link to v1: https://lore.kernel.org/r/20250902-rk3588-bgcolor-v1-0-fd97df91d89f@collabora.com > > --- > Cristian Ciocaltea (4): > uapi: Provide DIV_ROUND_CLOSEST() > drm: Add CRTC background color property > drm/vkms: Support setting custom background color > drm/rockchip: vop2: Support setting custom background color > > drivers/gpu/drm/drm_atomic_state_helper.c | 1 + > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ > drivers/gpu/drm/drm_blend.c | 39 ++++++++++++++-- > drivers/gpu/drm/drm_mode_config.c | 6 +++ > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 13 +++++- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 ++ > drivers/gpu/drm/vkms/vkms_composer.c | 10 ++++- > drivers/gpu/drm/vkms/vkms_crtc.c | 3 ++ > include/drm/drm_blend.h | 4 +- > include/drm/drm_crtc.h | 12 +++++ > include/drm/drm_mode_config.h | 5 +++ > include/linux/math.h | 18 +------- > include/uapi/drm/drm_mode.h | 67 ++++++++++++++++++++++++++++ > include/uapi/linux/const.h | 17 +++++++ > 14 files changed, 178 insertions(+), 25 deletions(-) > --- > base-commit: 8e7460eac786c72f48c4e04ce9be692b939428ce > change-id: 20250829-rk3588-bgcolor-c1a7b9a507bc > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip