From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D9ABD262B0 for ; Wed, 21 Jan 2026 08:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:Subject:Cc: To:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0neEmidtfdA/Yn6XvU5etJDpAKxEFDqqDn6xOgfQYKI=; b=fU9VLQbbk4aVbe Ef3YJKLTWEZLTJzdas1YWQFEQVYSVrcQlAPZ0EhjVZESLx5HysqNV5ImEpVcyOVA7q58zHD4L5h9J x/eyOQ5nRSIT6U2o47AEGfTYZj2G+CUYISwWIw7KVoJ0Lh/HM+oUbPGzNtI+ZItYb26d/aHtzTsxh nw6X/ZaHy2SWczRShoO7qOWqfXeUPZ1h9mZtt4389IW+9KmBm7YJqOq79depS4+ygx/dU/qEAKT0y mtulB09jsSx1wR2JhwbAyXPd9eRLru8NdFiZ2F0uA5axrECTD3feysnxGlSMx64yODlC7E0WLio7W QscqLMltYftpYmCodV1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1viTMB-000000054Gn-2eXt; Wed, 21 Jan 2026 08:14:27 +0000 Received: from out-182.mta1.migadu.com ([95.215.58.182]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1viTM8-000000054Es-2LQ7 for linux-rockchip@lists.infradead.org; Wed, 21 Jan 2026 08:14:25 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1768983252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yfisx39MoKyL9c3tUxQTaTOyIEsGPjfK03MuLUniLRw=; b=IHDluf3rviNEt+6PbCXoDsnMOzMhg8Q409a5vnXpMoZ7pLPnF52xoRtpuHQmx5bqU6huWm EeTvW4Q2PdpEic7wbdZLwVvj18ZhLDbsEO0tqI3cqjGSO3Hq6phrfPXYjIjzb11HvW7FTO iqy8bPi3hQcyLWztQrH/XsHtdOU6hauOBk6R0YppA1h2NeQKtGc+dgxVgMtInY4OFlREGH xWgfgixUu2uQzUKl5k7HquVn/UtfI02RpfpqgNDWTtBtR0qMCDeKNkom2rWklTa81z3lEA 8MS8e+cuS+3kM/fVMrlYlaUGsf5MYM4gAdnUli2Lah2z1a8WAhAc0cC6lOouxw== Date: Wed, 21 Jan 2026 09:14:05 +0100 Message-Id: To: "Chaoyi Chen" , "Andrew Lunn" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Alexey Charkov" , "Shawn Lin" , "Sebastian Reichel" , "Chaoyi Chen" , "Andy Yan" , "Nicolas Frattaroli" , "Detlev Casanova" , "Stephen Chen" Cc: , , , Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20260121031548.402-1-kernel@airkyi.com> <20260121031548.402-2-kernel@airkyi.com> In-Reply-To: <20260121031548.402-2-kernel@airkyi.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260121_001424_749447_FFA2A024 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed Jan 21, 2026 at 4:15 AM CET, Chaoyi Chen wrote: > From: Chaoyi Chen > > According to the description in the net documentation, PHY modes > "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal > to be delayed on the PCB. > > The Rockchip platform has long used the above mentioned PHY modes and > private delay prop to describe the internal IO delay settings of the > chip, which is inconsistent with what is described in the documentation. > > Let's describe this part of the delay in the PHY and use the more > reasonable "rgmii-id" mode. > > Signed-off-by: Chaoyi Chen > --- > arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts > index c5584c26db52..3ee76bafafb5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts > @@ -266,7 +266,7 @@ &combphy1_psu { > > &gmac0 { > clock_in_out = "output"; > - phy-mode = "rgmii-rxid"; > + phy-mode = "rgmii-id"; > phy-handle = <&rgmii_phy0>; > pinctrl-names = "default"; > pinctrl-0 = <ð0m0_miim > @@ -275,14 +275,13 @@ ð0m0_rx_bus2 > ð0m0_rgmii_clk > ð0m0_rgmii_bus > ðm0_clk0_25m_out>; > - tx_delay = <0x21>; This being '0x21' (not '0x20') ... > status = "okay"; > }; > > &gmac1 { > clock_in_out = "output"; > phy-handle = <&rgmii_phy1>; > - phy-mode = "rgmii-rxid"; > + phy-mode = "rgmii-id"; > pinctrl-names = "default"; > pinctrl-0 = <ð1m0_miim > ð1m0_tx_bus2 > @@ -290,7 +289,6 @@ ð1m0_rx_bus2 > ð1m0_rgmii_clk > ð1m0_rgmii_bus > ðm0_clk1_25m_out>; > - tx_delay = <0x20>; > status = "okay"; > }; > > @@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 { > reset-assert-us = <20000>; > reset-deassert-us = <100000>; > reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>; > + tx-internal-delay-ps = <1950>; ... shouldn't this be higher? 0.0579 * 0x21 + 0.105 = 2.0157 (not sure how the rounding goes) Cheers, Diederik > }; > }; > > @@ -737,6 +736,7 @@ rgmii_phy1: ethernet-phy@1 { > reset-assert-us = <20000>; > reset-deassert-us = <100000>; > reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>; > + tx-internal-delay-ps = <1950>; > }; > }; > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip