Re: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output

From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Christian Hewitt" <christianshewitt@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jonas Karlman <jonas@kwiboo.se>,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Douglas Anderson <dianders@chromium.org>,
	Sugar Zhang <sugar.zhang@rock-chips.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	David Airlie <airlied@gmail.com>,
	linux-kernel@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output
Date: Tue, 17 Mar 2026 18:35:58 +0100	[thread overview]
Message-ID: <DH58MAETGDMM.2QS6VJDQ7UXIV@bootlin.com> (raw)
In-Reply-To: <00EE3E21-F614-429B-ACB6-19AF64CF74B3@gmail.com>

Hello Christian, Cristian, Jonas,

On Tue Mar 17, 2026 at 5:49 PM CET, Christian Hewitt wrote:
>> On 17 Mar 2026, at 8:16 pm, Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>>
>> Hello Christian,
>>
>> On Sat Feb 28, 2026 at 12:28 PM CET, Christian Hewitt wrote:
>>> From: Jonas Karlman <jonas@kwiboo.se>
>>>
>>> Channel Allocation (PB4) and Level Shift Information (PB5) are
>>> configured with values from PB1 and PB2 due to the wrong offset
>>> being used. This results in missing audio channels or incorrect
>>> speaker placement when playing multi-channel audio.
>>>
>>> Use the correct offset to fix multi-channel audio output.
>>>
>>> Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp")
>>> Reported-by: Christian Hewitt <christianshewitt@gmail.com>
>>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>> Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>
>> While applying this patch to drm-mics-fixes, checkpatch complains:
>>
>>  -:14: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
>>
>> You can send v3 with the link, or just reply with the link and I'll take
>> care of adding it to the commit message.
>
> Apologies, it looks like use of Reported-by was tightened since I last
> used it, and there’s no official report anywhere I can link to (it was
> all done in private channels) so better to just drop it from the v2 patch
> if that’s possible? - if not I can send a v3 without it.

Thanks for the quick feedback.

I applied keeping the commit message as is. In lack of a public discussion
I guess the 'Reported-by' is somewhat informative anyway. I read the
checkpatch as a general suggestion, not a hard rule.

So now this patch is on drm-misc-fixes, but drm-misc-fixes and
drm-misc-next are now conflicting because of other changes by Cristian
Ciocaltea applied in the meanwhile to drm-misc-next, and particularly
commit 3ea699b56d31 ("drm/bridge: dw-hdmi-qp: Rework Audio InfoFrame
handler").

Cristian, Christian (heh), Jonas, could you please check whether the code
on drm-misc-next has or not the bug that is fixed here? And if it still
has, send a fix based on current drm-misc-next?

Thanks!

Best regards,
Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip