From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0395F43826 for ; Wed, 15 Apr 2026 14:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=slVF9qnhVuxxHznuEbqt7dTguv0Z0ep49KKi2tkMeaM=; b=wbqIC68GBO6Ptq I+K6cRfN7onUoRoN4C5QpXGdOUsHydFj2vfUUiUL30loar8sNMTvyVoAPTDfef4diHV49ePagir+Y szV8Mvuk0IhqmMkgm5hJvFEQVQHc5pHPPnfgRu8GiNGurVkYXF/JA0W8jUrsOC70iLkOn/SJs445G fBwNUWIwP9Pt7kajBHAObvL6bYJKowBMkmnLJrxxOq2Z281sX5v1fMK4wRBwhmt7QrYvMqj6lbsYm OYleOFBEb0EUNdgMdY4IIdyeWqhfHBrrx21WbbU2F+NZOBen4/zzAtl3F40VI1Fkhf/WQewqrp3g1 B0FliOkG7BwzOg2pbm9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wD19r-00000001EQK-1ger; Wed, 15 Apr 2026 14:23:59 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wD19p-00000001EP9-0tYa for linux-rockchip@lists.infradead.org; Wed, 15 Apr 2026 14:23:58 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1776263024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lL7mCvK+q0xGQs3fJVfkD8uIV04NWks6Q4iAT/RCikU=; b=PPHL3fohQaJmiY4FQ3bGdoLlnkxD3DisK+130lYMNRBUr9ElwIamQCUE8La68uEnzBM9ll Ez9FAtf7bXKW1YLoUZj3crkEVO5b9gunKXpt4z3HN23XsFJ/repsr5s0Qc78hxFvogqE1R cF1nPBz/cCsp9zaBAu2oba32v+2j4yHKzLuiAL77aqjiDdZcIJuesxvIyKjN+Nn6kFnCpZ vwqUzBhXnf+Bv/tWItCWac1wUOFmqa6ih3jzxcbL2qke2xl374U4NftWpEBUn/8oDX+8LC KmBqOC4QwmROWCuofnsiizJBZBK1pvMI5aWI+6vsn0/hSXw2Q2+MZbIPL1YJ0g== Date: Wed, 15 Apr 2026 16:23:41 +0200 Message-Id: Cc: "Arnd Bergmann" , , , , , "Quentin Schulz" , "Jonas Karlman" , "Tianling Shen" Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Replace deprecated snps,* props for NanoPi R5S X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Diederik de Haas" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" References: <20260401131551.734456-1-diederik@cknow-tech.com> <20260401131551.734456-3-diederik@cknow-tech.com> In-Reply-To: <20260401131551.734456-3-diederik@cknow-tech.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260415_072357_420745_95E8B939 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed Apr 1, 2026 at 3:11 PM CEST, Diederik de Haas wrote: > The various snps,reset-* properties are deprecated, so convert them into > their replacements. > > Signed-off-by: Diederik de Haas > --- > arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > index 90ce6f0e1dcf..92d044ec696b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > @@ -85,10 +85,6 @@ &gmac0_tx_bus2 > &gmac0_rx_bus2 > &gmac0_rgmii_clk > &gmac0_rgmii_bus>; > - snps,reset-gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; > - snps,reset-active-low; > - /* Reset time is 15ms, 50ms for rtl8211f */ > - snps,reset-delays-us = <0 15000 50000>; > tx_delay = <0x3c>; > rx_delay = <0x2f>; > status = "okay"; > @@ -100,6 +96,9 @@ rgmii_phy0: ethernet-phy@1 { > reg = <1>; > pinctrl-0 = <&gmac0_rstn_gpio0_c5_pin>; > pinctrl-names = "default"; > + reset-assert-us = <15000>; > + reset-deassert-us = <50000>; > + reset-gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; > }; > }; > Please disregard/drop this patch. I was recently made aware of 'sashiko.dev' and checked whether it had also checked my patch, which it did: https://sashiko.dev/#/patchset/20260401131551.734456-1-diederik%40cknow-tech.com And it turns out that the concern raised is valid (thanks Quentin!), so this patch could introduce a regression. So it looks like staying with the deprecated properties is actually better (in this case?). Cheers, Diederik _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip